You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/03 13:46:52 UTC

[GitHub] [shardingsphere] avalon5666 commented on a change in pull request #5894: Implement persistence task position info

avalon5666 commented on a change in pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894#discussion_r434579223



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/job/task/incremental/LogPositionManager.java
##########
@@ -15,25 +15,20 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.scaling.core.job.position;

Review comment:
       The LogPosition manager is the util to get current binlog(wal) position from database. I haven't found the suitable naming for it yet, just adjuest the package.
   Now the task position metadata manager is different class, the manager will refactor soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org