[GitHub] [beam] aaltay commented on a change in pull request #11020: [BEAM-7926] Update Data Visualization

[GitBox <gi...@apache.org>]

aaltay commented on a change in pull request #11020: [BEAM-7926] Update Data Visualization
URL: https://github.com/apache/beam/pull/11020#discussion_r387253892
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/display/pcoll_visualization.py
 ##########
 @@ -181,6 +247,12 @@ def __init__(self, pcoll):
     self._overview_display_id = 'facets_overview_{}_{}'.format(
         self._cache_key, id(self))
     self._df_display_id = 'df_{}_{}'.format(self._cache_key, id(self))
+    # Whether the visualization should include window info.
 
 Review comment:
   You can probably drop these comments. They are pretty obvious form variable names and use up to this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services