You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Richard Ding <rd...@yahoo-inc.com> on 2011/01/15 01:54:22 UTC
Review Request: Modify embedded Pig API for usability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/325/
-----------------------------------------------------------
Review request for pig and Julien Le Dem.
Summary
-------
See the description in PIG-1806.
This addresses bug PIG-1806.
https://issues.apache.org/jira/browse/PIG-1806
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/Pig.java 1059090
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/ScriptEngine.java 1059090
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java 1059090
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestScriptLanguage.java 1059090
Diff: https://reviews.apache.org/r/325/diff
Testing
-------
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Thanks,
Richard
Re: Review Request: Modify embedded Pig API for usability
Posted by Julien Le Dem <ju...@ledem.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/325/#review132
-----------------------------------------------------------
Ship it!
Looks good to me
- Julien
On 2011-01-14 16:54:22, Richard Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/325/
> -----------------------------------------------------------
>
> (Updated 2011-01-14 16:54:22)
>
>
> Review request for pig and Julien Le Dem.
>
>
> Summary
> -------
>
> See the description in PIG-1806.
>
>
> This addresses bug PIG-1806.
> https://issues.apache.org/jira/browse/PIG-1806
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/Pig.java 1059090
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/ScriptEngine.java 1059090
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/jython/JythonScriptEngine.java 1059090
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestScriptLanguage.java 1059090
>
> Diff: https://reviews.apache.org/r/325/diff
>
>
> Testing
> -------
>
> [exec] +1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 3 new or modified tests.
> [exec]
> [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
>
>
> Thanks,
>
> Richard
>
>