Re: [PR] MINOR: Disallow unused local variables [kafka]

["lucasbru (via GitHub)" <gi...@apache.org>]

lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1970132884


##########
generator/src/main/java/org/apache/kafka/message/checker/EvolutionVerifier.java:
##########
@@ -74,7 +74,7 @@ static void verifyVersionsMatchTopLevelMessage(
             verifyVersionsMatchTopLevelMessage(what, topLevelMessage, field);
         }
         for (StructSpec struct : topLevelMessage.commonStructs()) {
-            for (FieldSpec field : topLevelMessage.fields()) {
+            for (FieldSpec field : struct.fields()) {

Review Comment:
   This actually looks like a bug to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org