You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/05 12:52:00 UTC
[jira] [Commented] (FLINK-8703) Migrate tests from
LocalFlinkMiniCluster to MiniClusterResource
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386031#comment-16386031 ]
ASF GitHub Bot commented on FLINK-8703:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5636
[FLINK-8703][tests] Port CancelingTestBase to MiniClusterResource
## What is the purpose of the change
The `CancelingTestBase` now uses the `MiniClusterResource` and can be run against both legacy and flip6 clusters.
## Brief change log
* Do not use singleActorSystem in LocalFlinkMiniCluster as this rendered the returned client to be unusable
* port `CancelingTestBase`
* properly disable JoinCancelingITCase
## Verifying this change
Run `MapCancelingITCase` with flip6 profile on/off.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8703_canceling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5636
----
commit 24d95a00164f4b93ff30a237680cf4772855d7fc
Author: zentol <ch...@...>
Date: 2018-03-05T12:45:33Z
[hotfix][tests] Do not use singleActorSystem in LocalFlinkMiniCluster
Using a singleActorSystem rendered the returned client unusable.
commit 3fad83426a6356dee7966cf9e55d0de40b3bf6da
Author: zentol <ch...@...>
Date: 2018-02-26T14:36:37Z
[FLINK-8703][tests] Port CancelingTestBase to MiniClusterResource
commit 07c77df577e62bcbfc4aeac3e5220151768319dd
Author: zentol <ch...@...>
Date: 2018-02-28T12:43:42Z
[hotfix][tests] Properly disable JoinCancelingITCase
----
> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
> Key: FLINK-8703
> URL: https://issues.apache.org/jira/browse/FLINK-8703
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Aljoscha Krettek
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)