You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/05/16 19:59:27 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #31328: Add missing priorityClassName to K8S worker pod template
hussein-awala opened a new pull request, #31328:
URL: https://github.com/apache/airflow/pull/31328
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #31311
This PR adds `priorityClassName` to the pod template of the KubernetesExecutor workers when it is provided to `Values.workers.priorityClassName`
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #31328:
URL: https://github.com/apache/airflow/pull/31328#issuecomment-1568413876
> @hussein-awala why dont we also add these changes in `chart/templates/workers/worker-deployment.yaml`?
Nevermind. I see that is already exisst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #31328:
URL: https://github.com/apache/airflow/pull/31328#discussion_r1210100456
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -80,6 +80,9 @@ spec:
{{- if .Values.workers.extraContainers }}
{{- toYaml .Values.workers.extraContainers | nindent 4 }}
{{- end }}
+ {{- if .Values.workers.priorityClassName }}
+ priorityClassName: {{ .Values.workers.priorityClassName }}
+ {{- end }}
Review Comment:
you can add this as a new feature in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #31328:
URL: https://github.com/apache/airflow/pull/31328#discussion_r1210212022
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -80,6 +80,9 @@ spec:
{{- if .Values.workers.extraContainers }}
{{- toYaml .Values.workers.extraContainers | nindent 4 }}
{{- end }}
+ {{- if .Values.workers.priorityClassName }}
+ priorityClassName: {{ .Values.workers.priorityClassName }}
+ {{- end }}
Review Comment:
Sure, thank you. Will create one soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #31328:
URL: https://github.com/apache/airflow/pull/31328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #31328:
URL: https://github.com/apache/airflow/pull/31328#issuecomment-1550944794
@jedcunningham can you check it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #31328:
URL: https://github.com/apache/airflow/pull/31328#discussion_r1200251031
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -80,6 +80,9 @@ spec:
{{- if .Values.workers.extraContainers }}
{{- toYaml .Values.workers.extraContainers | nindent 4 }}
{{- end }}
+ {{- if .Values.workers.priorityClassName }}
+ priorityClassName: {{ .Values.workers.priorityClassName }}
+ {{- end }}
Review Comment:
I think we should also have a priority class definition in the code base. Otherwise users will be expected to create their own priorityclasses and then only run this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #31328: Add missing priorityClassName to K8S worker pod template
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #31328:
URL: https://github.com/apache/airflow/pull/31328#issuecomment-1550721782
Can you add a test [here](https://github.com/apache/airflow/blob/main/tests/charts/airflow_aux/test_pod_template_file.py)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org