You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Jichao Wang (Jira)" <ji...@apache.org> on 2022/12/10 12:07:00 UTC
[jira] [Commented] (DIRKRB-762) The AS request appears with an NPE when preauth_required is set to false
[ https://issues.apache.org/jira/browse/DIRKRB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645594#comment-17645594 ]
Jichao Wang commented on DIRKRB-762:
------------------------------------
Hi [~coheigea] , can you help me confirm if this is a bug? If yes, please review my code. I have create a pull request to solve this problem.
> The AS request appears with an NPE when preauth_required is set to false
> ------------------------------------------------------------------------
>
> Key: DIRKRB-762
> URL: https://issues.apache.org/jira/browse/DIRKRB-762
> Project: Directory Kerberos
> Issue Type: Bug
> Affects Versions: 2.0.0, 2.0.1, 2.0.2
> Reporter: Jichao Wang
> Priority: Major
> Fix For: 2.0.3
>
>
> If change the value of preauth_required in the kdc.conf file to false, then using the following code to access the KDC causes an NPE error.
> {code:java}
> public class Test {
> public static void main(String[] args) throws Exception {
> LoginContext lc = new LoginContext("SampleClient",
> new Subject(),
> null,
> new CustomConfiguration("hadoop@HADOOP.COM", "/root/wjc/hadoop.keytab"));
> lc.login();
> System.out.println(lc.getSubject().toString());
> }
> } {code}
> Here is a fix to the problem:
> {code:java}
> Index: kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> diff --git a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
> --- a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java (revision 03784fcde8e94fedbe789606d2f328104c20b33f)
> +++ b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java (date 1670208307220)
> @@ -678,11 +678,13 @@
> }
>
> PaData preAuthData = request.getPaData();
> - if (isPreauthRequired() && (preAuthData == null || preAuthData.isEmpty())) {
> - LOG.info("The preauth data is empty.");
> - KrbError krbError = makePreAuthenticationError(kdcContext, request,
> - KrbErrorCode.KDC_ERR_PREAUTH_REQUIRED, false);
> - throw new KdcRecoverableException(krbError);
> + if (isPreauthRequired()) {
> + if (preAuthData == null || preAuthData.isEmpty()) {
> + LOG.info("The preauth data is empty.");
> + KrbError krbError = makePreAuthenticationError(kdcContext, request,
> + KrbErrorCode.KDC_ERR_PREAUTH_REQUIRED, false);
> + throw new KdcRecoverableException(krbError);
> + }
> } else {
> getPreauthHandler().verify(this, preAuthData);
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org