You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/23 12:57:52 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #667: ORC-772: Fix Spark benchmark jar creation

dongjoon-hyun opened a new pull request #667:
URL: https://github.com/apache/orc/pull/667


   ### What changes were proposed in this pull request?
   
   This PR aims to fix Spark benchmark jar creation by using the default Maven shade plugin configurations explicitly. Otherwise, the parent pom's configuration is applied.
   
   ### Why are the changes needed?
   
   Since ORC-750, it builds incorrect uber jar. 
   ```
   $ cd java/bench
   
   $ mvn clean package -pl spark --am
   
   $ ls -alh spark/target/*.jar      
   -rw-rw-r-- 1 dongjoon dongjoon  62K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
   -rw-rw-r-- 1 dongjoon dongjoon 808K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT-nohive.jar
   ```
   
   ### How was this patch tested?
   
   Manually.
   ```
   $ cd java/bench
   
   $ mvn clean package -pl spark --am
   
   $ ls -alh spark/target/*.jar
   -rw-rw-r-- 1 dongjoon dongjoon 130M Mar 23 05:56 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
   -rw-rw-r-- 1 dongjoon dongjoon  62K Mar 23 05:55 spark/target/original-orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #667: ORC-772: Fix Spark benchmark jar creation

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #667:
URL: https://github.com/apache/orc/pull/667#issuecomment-804906608


   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #667: ORC-772: Fix Spark benchmark jar creation

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #667:
URL: https://github.com/apache/orc/pull/667#issuecomment-804881843


   cc @omalley and @pgaref 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #667: ORC-772: Fix Spark benchmark jar creation

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #667:
URL: https://github.com/apache/orc/pull/667


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org