[jira] [Commented] (PIG-3623) Documentation for loadKey in HBaseStorage is incorrect

["Prashant Kommireddi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856804#comment-13856804 ] 

Prashant Kommireddi commented on PIG-3623:
------------------------------------------

Thanks [~mstefaniak]. This actually sounds like a bug, the following would fix it.

{code}
if(configuredOptions_.hasOption("loadKey")) {
    loadRowKey_ = configuredOptions_.getOptionValue("loadKey");
}
{code}

[~rohini] [~billgraham] would this be backward incompatible? Its the right thing to do w.r.t docs, but I am not sure if this will throw users off because of current behavior?

> Documentation for loadKey in HBaseStorage is incorrect
> ------------------------------------------------------
>
>                 Key: PIG-3623
>                 URL: https://issues.apache.org/jira/browse/PIG-3623
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Michael Stefaniak
>
> The documentation for HBaseStorage (http://pig.apache.org/docs/r0.12.0/func.html#HBaseStorage)
> says -loadKey=(true|false) Load the row key as the first value in every tuple returned from HBase (default=false)
> However, looking at the source (http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java)
> it is just doing a check for the existence of this option
> loadRowKey_ = configuredOptions_.hasOption("loadKey");
> So setting -loadKey=false in the options string, still results in a true value



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)