You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by ho...@apache.org on 2023/08/01 21:49:34 UTC
[solr] branch main updated: SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)
This is an automated email from the ASF dual-hosted git repository.
houston pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/main by this push:
new 5926eda577a SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)
5926eda577a is described below
commit 5926eda577aa2ab3316898a44bb59382367d3e9e
Author: Houston Putman <ho...@apache.org>
AuthorDate: Tue Aug 1 17:49:27 2023 -0400
SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)
---
solr/CHANGES.txt | 2 ++
.../solr/cluster/placement/plugins/AffinityPlacementConfig.java | 2 +-
.../modules/configuration-guide/pages/replica-placement-plugins.adoc | 2 +-
.../modules/upgrade-notes/pages/major-changes-in-solr-9.adoc | 4 ++++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 9647e7d7eee..7fe2590a383 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -101,6 +101,8 @@ Other Changes
* SOLR-16803: Remove dependencies on methods defined in the SimplePostTool from Solr core and solrj modules.
+* SOLR-16915: Lower the AffinityPlacementPlugin's default minimalFreeDiskGB to 5 GB (Houston Putman)
+
================== 9.3.0 ==================
Upgrade Notes
diff --git a/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java b/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
index 2a5d2bdb4a6..2622082a296 100644
--- a/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
+++ b/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
@@ -28,7 +28,7 @@ import org.apache.solr.common.annotation.JsonProperty;
/** Configuration bean for {@link AffinityPlacementFactory}. */
public class AffinityPlacementConfig implements PlacementPluginConfig {
- public static final long DEFAULT_MINIMAL_FREE_DISK_GB = 20L;
+ public static final long DEFAULT_MINIMAL_FREE_DISK_GB = 5L;
public static final long DEFAULT_PRIORITIZED_FREE_DISK_GB = 100L;
public static final AffinityPlacementConfig DEFAULT =
diff --git a/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc b/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
index 1f5f19e14ae..4556574ea51 100644
--- a/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
+++ b/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
@@ -147,7 +147,7 @@ This plugin supports the following configuration parameters:
+
[%autowidth,frame=none]
|===
-|Optional |Default: `20` Gigabytes
+|Optional |Default: `5` Gigabytes
|===
+
If a node has strictly less GB of free disk than this value, the node is excluded from assignment decisions.
diff --git a/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc b/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
index e1cd003fc69..750919eabef 100644
--- a/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
+++ b/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
@@ -72,6 +72,10 @@ Please refer to the xref:configuration-guide:commits-transaction-logs.html#hard-
for more information on how this change will effect you.
Upgrading existing clouds and use-cases that have custom configSets will not be affected by this change.
+=== Replica Placements
+* The default `minimalFreeDiskGB` value has been lowered from `20GB` to `5GB` when using the xref:configuration-guide:replica-placement-plugins.adoc#affinityplacementfactory[AffinityPlacementPlugin].
+Therefore, when using the default settings, nodes that were previously excluded from Replica placements due to low available disk space may be selected after upgrading.
+
== Solr 9.3
=== Binary Releases