You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/07/31 02:33:47 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2696: [GOBBLIN-837] refactor FlowConfigV2Client and FlowStatusClient to allow child class…
codecov-io commented on issue #2696: [GOBBLIN-837] refactor FlowConfigV2Client and FlowStatusClient to allow child class…
URL: https://github.com/apache/incubator-gobblin/pull/2696#issuecomment-516669131
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=h1) Report
> Merging [#2696](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/28dcd62e9d2041969b041de104f5242150f95a06?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2696 +/- ##
===========================================
- Coverage 44.84% 44.8% -0.04%
+ Complexity 8693 8689 -4
===========================================
Files 1878 1878
Lines 70058 70059 +1
Branches 7701 7701
===========================================
- Hits 31417 31391 -26
- Misses 35737 35765 +28
+ Partials 2904 2903 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `74.46% <ø> (-0.08%)` | `11 <0> (ø)` | |
| [...a/org/apache/gobblin/service/FlowStatusClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzQ2xpZW50LmphdmE=) | `72.34% <50%> (+0.6%)` | `7 <1> (+1)` | :arrow_up: |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `69.62% <50%> (+0.38%)` | `10 <1> (+1)` | :arrow_up: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70% <0%> (-30%)` | `3% <0%> (-2%)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `57.62% <0%> (-7.35%)` | `21% <0%> (ø)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.41% <0%> (-3.48%)` | `9% <0%> (ø)` | |
| [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==) | `81.25% <0%> (-2.09%)` | `26% <0%> (-2%)` | |
| [...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=) | `39.21% <0%> (-1.31%)` | `6% <0%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2696/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=footer). Last update [28dcd62...20654ea](https://codecov.io/gh/apache/incubator-gobblin/pull/2696?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services