You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by michaelandersen <gi...@git.apache.org> on 2015/08/24 17:35:40 UTC
[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...
GitHub user michaelandersen opened a pull request:
https://github.com/apache/cloudstack/pull/738
Fix for missing defaultroute on VPC router
https://issues.apache.org/jira/browse/CLOUDSTACK-8685
Refactored CsRoute and CsAddress to:
- add methods to add and verify the defaultroute
- renamed methods flush, add, and routeTable to flush_table, add_route, add_table respectively.
Added some suboptimal unit tests to TestCsRoutes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandersen/cloudstack vpc_defaultroute_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #738
----
commit bb93a61ee70de491ef52806785828e3903f53853
Author: Michael Andersen <ma...@schubergphilis.com>
Date: 2015-08-24T09:59:35Z
pep8 cleanup
commit a9eb4ba5c90136176b5ec395f0444a489abc639e
Author: Michael Andersen <ma...@schubergphilis.com>
Date: 2015-08-24T10:53:19Z
Fixed defaultroute on VPC routers in CsRoute and CsAddress
Refactored CsRoute
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...
Posted by jayapalu <gi...@git.apache.org>.
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/738#issuecomment-134521171
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/738#issuecomment-134343822
LGTM
Deployed advanced zone with two VPCs, each with a tier, two VMs. Verified the default routes were there (and that the VMs could reach the internet)
```
root@r-6-VM:~# ip route show
default via 192.168.23.1 dev eth1
10.0.2.0/24 dev eth2 proto kernel scope link src 10.0.2.1
169.254.0.0/16 dev eth0 proto kernel scope link src 169.254.1.232
192.168.23.0/24 dev eth1 proto kernel scope link src 192.168.23.5
```
Note: In my dev environment `192.168.23.1` is the public gateway.
Created site-to-site VPNs and now those also work without modification.
Nice work @michaelandersen :-)
Minor comment: please prepend the PR title with "CLOUDSTACK-8685: "
@karuturi @jayapalu Could one of you also review this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/738#issuecomment-134503158
I do not understand most of this stuff. not a good candidate to review :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---