You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/08/24 05:32:25 UTC
(datafusion) branch gh-readonly-queue/main/pr-24544-b9a005367720af2ed54393c86016147cfb2c6e90 created (now 4c8e04d5b4)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-24544-b9a005367720af2ed54393c86016147cfb2c6e90
in repository https://gitbox.apache.org/repos/asf/datafusion.git
at 4c8e04d5b4 chore: add missing `since` versions to `#[deprecated]` attributes (#24544)
This branch includes the following new commits:
new 4c8e04d5b4 chore: add missing `since` versions to `#[deprecated]` attributes (#24544)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
(datafusion) 01/01: chore: add missing `since` versions to `#[deprecated]` attributes (#24544)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-24544-b9a005367720af2ed54393c86016147cfb2c6e90
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit 4c8e04d5b4ed705813266c07ddc5d0cc21af2552
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Mon Aug 24 05:32:01 2026 +0000
chore: add missing `since` versions to `#[deprecated]` attributes (#24544)
## Which issue does this PR close?
- Cleanup from looking for deprecated APIs
## Rationale for this change
The [API health policy deprecation guidelines] say:
> Mark the API as deprecated using `#[deprecated]` and specify the exact
DataFusion version in which it was deprecated
Five `#[deprecated]` attributes on `main` have no `since`, so there is
no way to tell when they can be removed
[API health policy deprecation guidelines]:
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
## What changes are included in this PR?
Adds `since` to each of the five. The version is the release that first
contained the commit which added the attribute, determined with `git tag
--contains`:
## Are these changes tested?
CI
## Are there any user-facing changes?
No
---
datafusion/core/src/physical_planner.rs | 4 ++--
datafusion/functions/src/string/overlay.rs | 1 +
datafusion/optimizer/src/push_down_filter.rs | 2 +-
datafusion/physical-plan/src/spill/spill_pool.rs | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/datafusion/core/src/physical_planner.rs b/datafusion/core/src/physical_planner.rs
index 5986c0498d..dcf64ee84e 100644
--- a/datafusion/core/src/physical_planner.rs
+++ b/datafusion/core/src/physical_planner.rs
@@ -2560,7 +2560,7 @@ type AggregateExprWithOptionalArgs = (
);
/// Create an aggregate expression with a name from a logical expression
-#[deprecated(note = "use LoweredAggregateBuilder")]
+#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")]
pub fn create_aggregate_expr_with_name_and_maybe_filter(
e: &Expr,
name: Option<String>,
@@ -2587,7 +2587,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter(
}
/// Create an aggregate expression from a logical expression or an alias
-#[deprecated(note = "use LoweredAggregateBuilder")]
+#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")]
pub fn create_aggregate_expr_and_maybe_filter(
e: &Expr,
logical_input_schema: &DFSchema,
diff --git a/datafusion/functions/src/string/overlay.rs b/datafusion/functions/src/string/overlay.rs
index 4a665dfde2..4adb9cafcb 100644
--- a/datafusion/functions/src/string/overlay.rs
+++ b/datafusion/functions/src/string/overlay.rs
@@ -16,6 +16,7 @@
// under the License.
#[deprecated(
+ since = "47.0.0",
note = "overlay has been moved to core. Update imports to use core::overlay."
)]
pub use crate::core::overlay::*;
diff --git a/datafusion/optimizer/src/push_down_filter.rs b/datafusion/optimizer/src/push_down_filter.rs
index cf54ae2547..8f72c1a8c3 100644
--- a/datafusion/optimizer/src/push_down_filter.rs
+++ b/datafusion/optimizer/src/push_down_filter.rs
@@ -1343,7 +1343,7 @@ fn rewrite_projection(
/// Creates a new LogicalPlan::Filter node.
///
/// Deprecated: use [`Filter::try_new`] directly.
-#[deprecated]
+#[deprecated(since = "55.0.0", note = "Use `Filter::try_new` instead")]
pub fn make_filter(predicate: Expr, input: Arc<LogicalPlan>) -> Result<LogicalPlan> {
Filter::try_new(predicate, input).map(LogicalPlan::Filter)
}
diff --git a/datafusion/physical-plan/src/spill/spill_pool.rs b/datafusion/physical-plan/src/spill/spill_pool.rs
index b787c62af3..56d8d11201 100644
--- a/datafusion/physical-plan/src/spill/spill_pool.rs
+++ b/datafusion/physical-plan/src/spill/spill_pool.rs
@@ -476,7 +476,7 @@ pub fn spsc_channel(
}
/// Alias for [`mpsc_channel`].
-#[deprecated(note = "Use mpsc_channel instead")]
+#[deprecated(since = "55.0.0", note = "Use mpsc_channel instead")]
pub fn channel(
max_file_size_bytes: usize,
spill_manager: Arc<SpillManager>,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org