You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/02/05 11:42:10 UTC

[GitHub] [commons-io] XenoAmess edited a comment on pull request #325: Handle static method isCaseSensitive of class IOCase.

XenoAmess edited a comment on pull request #325:
URL: https://github.com/apache/commons-io/pull/325#issuecomment-1030606272


   > Hello @code-ferry This PR needs a test that fails when the main side of the changes are not applied. Otherwise, if the main code changes back in the future, no one will know it breaks behavior. You will need to test all values.
   
   @garydgregory 
   IMO the test should not be added now, but should be added when the original codes written.
   If the codes is added into the lib with test, I don't think mistake in this level should happened.
   (however we cannot change what happened already; adding the tests now is a better choice than doing nothing.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org