[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3329: Fix: Migration target has no matching tags

[GitBox <gi...@apache.org>]

GabrielBrascher opened a new pull request #3329: Fix: Migration target has no matching tags
URL: https://github.com/apache/cloudstack/pull/3329
 
 
   ## Description
   <!--- Describe your changes in detail -->
   The code prior to this commit was looking into storage tags at the table `storage_pool_details`. However, the table. It should select from `storage_pool_tags`, which contains the tags from each tagged storage.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   Migrated a volume with a tag 'A' to a storage pool that also has the tag 'A'. Resulted on the following exception:
   ```
   2019-05-10 17:03:16,343 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-9:ctx-1255172b job-16095) (logid:3f7e0f22) Unexpected exception while executing org.apache.cloudstack.api.command.admin.volume.MigrateVolumeCmdByAdmin
   com.cloud.utils.exception.CloudRuntimeException: Migration target has no matching tags for volume 'ROOT-2086(262d639d-a0b0-4f8d-9e86-01fb210ace8f)'
           at com.cloud.storage.VolumeApiServiceImpl.migrateVolume(VolumeApiServiceImpl.java:2086)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
   ```
   After update with the proposed fix, the volume got migrated successfully.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services