You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/03/15 11:17:04 UTC
Review Request 57638: RANGER-1457 - Move COMPONENT_INSTALL_DIR_NAME to
install.properties for Yarn plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57638/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1457
https://issues.apache.org/jira/browse/RANGER-1457
Repository: ranger
Description
-------
Currently, you set the COMPONENT_INSTALL_DIR_NAME in yarn-plugin-install.properties. However, it makes more sense to follow the convention used by the hdfs plugin and to put COMPONENT_INSTALL_DIR_NAME in install.properties instead.
Diffs
-----
plugin-yarn/scripts/install.properties 9c11271
plugin-yarn/scripts/yarn-plugin-install.properties 074bc4d
src/main/assembly/plugin-yarn.xml 75b312c
Diff: https://reviews.apache.org/r/57638/diff/1/
Testing
-------
Tested installing the Yarn plugin with Hadoop.
Thanks,
Colm O hEigeartaigh
Re: Review Request 57638: RANGER-1457 - Move
COMPONENT_INSTALL_DIR_NAME to install.properties for Yarn plugin
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57638/#review171335
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On March 15, 2017, 11:17 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57638/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 11:17 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1457
> https://issues.apache.org/jira/browse/RANGER-1457
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, you set the COMPONENT_INSTALL_DIR_NAME in yarn-plugin-install.properties. However, it makes more sense to follow the convention used by the hdfs plugin and to put COMPONENT_INSTALL_DIR_NAME in install.properties instead.
>
>
> Diffs
> -----
>
> plugin-yarn/scripts/install.properties 9c11271
> plugin-yarn/scripts/yarn-plugin-install.properties 074bc4d
> src/main/assembly/plugin-yarn.xml 75b312c
>
>
> Diff: https://reviews.apache.org/r/57638/diff/1/
>
>
> Testing
> -------
>
> Tested installing the Yarn plugin with Hadoop.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>