You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/27 00:05:23 UTC

[GitHub] [airflow] SamWheating commented on a change in pull request #17446: Add support of `path` parameter for GCloud Storage Transfer Service operators

SamWheating commented on a change in pull request #17446:
URL: https://github.com/apache/airflow/pull/17446#discussion_r716284370



##########
File path: airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py
##########
@@ -885,7 +892,7 @@ def _create_body(self) -> dict:
             STATUS: GcpTransferJobsStatus.ENABLED,
             TRANSFER_SPEC: {
                 AWS_S3_DATA_SOURCE: {BUCKET_NAME: self.s3_bucket},

Review comment:
       Maybe we should add the option to include a source path here at the same time? It looks like the transferSpec supports a path argument for S3 bucket sources
   
   https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec#AwsS3Data




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org