You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/26 07:11:40 UTC
Re: Review Request 42586: Defined the NetClsHandleMgr class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 6:11 a.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Defined the NetClsHandleMgr class.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
Defined the NetClsHandleMgr class. This class will be responsible for keeping track of the free and allocated net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 7ce5243ed7476a1cfd1371b5ce25b62dc07432db
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 0798de747627ccc45b01a2668e16693757dc69a8
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 1, 2016, 1:46 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 44
> > <https://reviews.apache.org/r/42586/diff/5/?file=1227352#file1227352line44>
> >
> > s/issue/issues
Thanks for catching this.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
-----------------------------------------------------------
On Jan. 31, 2016, 5:45 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 37 - 38)
<https://reviews.apache.org/r/42586/#comment178256>
Add a blank line here
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 44)
<https://reviews.apache.org/r/42586/#comment178254>
s/issue/issues
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 88 - 89)
<https://reviews.apache.org/r/42586/#comment178257>
"A net_cls handle is composed of a 16-bit major and a 16-bit minor handle." This was already mentioned above for `NetClsHandle`
- Guangya Liu
On 一月 31, 2016, 5:45 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated 一月 31, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117534
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 74)
<https://reviews.apache.org/r/42586/#comment178748>
s/NetClsHandleMgr/NetClsHandleManager/
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 83)
<https://reviews.apache.org/r/42586/#comment178735>
s/allocMajor/allocPrimary/
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 91)
<https://reviews.apache.org/r/42586/#comment178737>
Two things:
1) Can you `s/_netClsHandles/used/`?
2) Can you just use bitset<0x10000> here? No need for the constant.
- Jie Yu
On Feb. 3, 2016, 12:43 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 12:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleManager class.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117629
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 25)
<https://reviews.apache.org/r/42586/#comment178869>
c headers needs to be included first. Please put this on the top.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 87)
<https://reviews.apache.org/r/42586/#comment178868>
We rarely use typedef in our code base. We try to avoid typedef because it hurts readability (readers need to jump around and don't know the underlying type).
- Jie Yu
On Feb. 3, 2016, 6:44 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 6:44 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleManager class.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117633
-----------------------------------------------------------
Looks good. Some minor comments modulo Jie's earlier comments.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 41)
<https://reviews.apache.org/r/42586/#comment178878>
Nit: Can you add a new line before the `TODO`?
Similar reasoning as to my comment on r42587 earlier.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 48)
<https://reviews.apache.org/r/42586/#comment178875>
Why do you need this default constructor?
Also, are you sure the standard gurrantees that member values would be zero initialized? I thought that the default initialization happens only for `POD` types?
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 53)
<https://reviews.apache.org/r/42586/#comment178873>
Can we make this constructor explicit to avoid implicit conversions?
- Anand Mazumdar
On Feb. 3, 2016, 6:44 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 6:44 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleManager class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 8:43 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleManager class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 6:44 a.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Defined the NetClsHandleManager class.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 12:43 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 5:52 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Guangya Liu <gy...@gmail.com>.
> On 二月 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 40
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line40>
> >
> > 2 blank lines above please.
Does there are any policies for this when need one blank line and when need two blank line?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117225
-----------------------------------------------------------
On 二月 1, 2016, 2:20 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated 二月 1, 2016, 2:20 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 65-75
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line65>
> >
> > Why do we need this?
Was using this data structure to pass on the usage of handles for a given major handle. It was useful in unit-testing, but thought will be useful in implementing a usage interface to the NetClsHandleMgr class. Should I keep it?
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 108-113
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line108>
> >
> > We do you need this in this patch?
There are quite a few places where we are throwing erros and need to convert the major and minor handle into a hex string, hence thought implement this as a static function (maybe inline) . Should I keep this?
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 40
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line40>
> >
> > 2 blank lines above please.
>
> Guangya Liu wrote:
> Does there are any policies for this when need one blank line and when need two blank line?
The coding guide lines give the following rule:
"Elements outside classes (classes, structs, global functions, etc.) should be spaced apart by two empty lines."
So from that perspective this makes sense.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117225
-----------------------------------------------------------
On Feb. 1, 2016, 2:20 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 2:20 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleManager class.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 51-52
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line51>
> >
> > `s/majHandle/_major/`
> > `s/minHandle/_minor/`
> >
> > Also, remove the space right after `NetClsHandle`
Using primary and secondary instead of major and minor.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 65-75
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line65>
> >
> > Why do we need this?
>
> Avinash sridharan wrote:
> Was using this data structure to pass on the usage of handles for a given major handle. It was useful in unit-testing, but thought will be useful in implementing a usage interface to the NetClsHandleMgr class. Should I keep it?
Removed this structure. We no longer need it.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 78-85
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line78>
> >
> > I would suggest that we don't define a new data structure for this. Can you just inline it in NetClsHandleManager?
Simplified the data structure. We no longer need an explicit NetClsHandles structure.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 108-113
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line108>
> >
> > We do you need this in this patch?
>
> Avinash sridharan wrote:
> There are quite a few places where we are throwing erros and need to convert the major and minor handle into a hex string, hence thought implement this as a static function (maybe inline) . Should I keep this?
Removed this structure from this patch. Will re-introduce it when we introduce the implementation.
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 129
> > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line129>
> >
> > What's the key for this map?
Added a comment to elaborate on the key.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117225
-----------------------------------------------------------
On Feb. 3, 2016, 6:44 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 6:44 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117225
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 40)
<https://reviews.apache.org/r/42586/#comment178343>
2 blank lines above please.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 43 - 44)
<https://reviews.apache.org/r/42586/#comment178344>
I would say it's due to the fact that it depends on libnl headers and we cannot bundle libnl since it has GPL licensing.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 51 - 52)
<https://reviews.apache.org/r/42586/#comment178346>
`s/majHandle/_major/`
`s/minHandle/_minor/`
Also, remove the space right after `NetClsHandle`
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 54)
<https://reviews.apache.org/r/42586/#comment178347>
Ditto on removing the extra space.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 60 - 61)
<https://reviews.apache.org/r/42586/#comment178345>
s/majorHandle/major/
s/minorHandle/minor/
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 65 - 75)
<https://reviews.apache.org/r/42586/#comment178357>
Why do we need this?
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 78 - 85)
<https://reviews.apache.org/r/42586/#comment178356>
I would suggest that we don't define a new data structure for this. Can you just inline it in NetClsHandleManager?
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 98 - 100)
<https://reviews.apache.org/r/42586/#comment178348>
```
NetClsHandleManager(const IntervalSet<uint16_t>& _majors)
: majors(_majors) {}
```
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 101 - 104)
<https://reviews.apache.org/r/42586/#comment178349>
```
majors(_majors)
```
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 108 - 113)
<https://reviews.apache.org/r/42586/#comment178350>
We do you need this in this patch?
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 117)
<https://reviews.apache.org/r/42586/#comment178353>
Remove the blank line here.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 118)
<https://reviews.apache.org/r/42586/#comment178351>
s/majorHandle/major/
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 121)
<https://reviews.apache.org/r/42586/#comment178352>
Remove the blank ine here.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 129)
<https://reviews.apache.org/r/42586/#comment178355>
What's the key for this map?
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 131)
<https://reviews.apache.org/r/42586/#comment178354>
`s/_majorHandles/majors/`
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 53)
<https://reviews.apache.org/r/42586/#comment178342>
insert one blank line above.
- Jie Yu
On Feb. 1, 2016, 2:20 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 2:20 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
>
> Diff: https://reviews.apache.org/r/42586/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 2:20 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42586: Defined the NetClsHandleMgr class.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 5:45 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345
Repository: mesos
Description (updated)
-------
This class will be responsible for keeping track of the free and allocated
net_cls handles.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
Diff: https://reviews.apache.org/r/42586/diff/
Testing
-------
make
Thanks,
Avinash sridharan