[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #110: Introduce gorilla encoder to measure

[GitBox <gi...@apache.org>]

hanahmily commented on code in PR #110:
URL: https://github.com/apache/skywalking-banyandb/pull/110#discussion_r858465285


##########
banyand/measure/measure.go:
##########
@@ -70,10 +73,14 @@ func (s *measure) Close() error {
 	return s.indexWriter.Close()
 }
 
-func (s *measure) parseSpec() {
+func (s *measure) parseSpec() (err error) {
 	s.name, s.group = s.schema.GetMetadata().GetName(), s.schema.GetMetadata().GetGroup()
 	s.entityLocator = partition.NewEntityLocator(s.schema.GetTagFamilies(), s.schema.GetEntity())
 	s.maxObservedModRevision = pbv1.ParseMaxModRevision(s.indexRules)
+	if s.schema.Interval != "" {

Review Comment:
   absolutely, the interval of `service_traffic` is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org