You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/08 20:48:54 UTC
[GitHub] [airflow-site] XD-DENG opened a new pull request #304: Fix Search Page
XD-DENG opened a new pull request #304:
URL: https://github.com/apache/airflow-site/pull/304
This PR fixes the issue I reported earlier in https://github.com/apache/airflow-site/issues/303 (Search Page not working properly).
I'm not so sure about the doc generating process here, especially how the search page is generated (like whether it's based on a template. I tried to find it but failed). So in this PR, I only fixed the issue in all applicable cases in `/docs-archive`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] mik-laj commented on pull request #304: Fix Search Page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #304:
URL: https://github.com/apache/airflow-site/pull/304#issuecomment-723664133
Can you update template also?
https://github.com/apache/airflow-site/blob/master/sphinx_airflow_theme/sphinx_airflow_theme/breadcrumbs.html#L38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] mik-laj merged pull request #304: Fix Search Page
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #304:
URL: https://github.com/apache/airflow-site/pull/304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] mik-laj commented on pull request #304: Fix Search Page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #304:
URL: https://github.com/apache/airflow-site/pull/304#issuecomment-723664603
I am waiting for the documentation to be built on CI and I will see if everything works.
https://github.com/apache/airflow-site/blob/master/CONTRIBUTE.md#preview-changes-on-pull-requests-cicd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] XD-DENG commented on pull request #304: Fix Search Page
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #304:
URL: https://github.com/apache/airflow-site/pull/304#issuecomment-723664464
> Can you update template also?
> https://github.com/apache/airflow-site/blob/master/sphinx_airflow_theme/sphinx_airflow_theme/breadcrumbs.html#L38
Cool. Thanks @mik-laj . This is exactly what I was looking for just now but failed to.
Fixed. Mind taking another look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org