You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/13 06:01:15 UTC

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

SteNicholas commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825392629



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -44,6 +45,10 @@ class SparkProcessBuilder(
 
   import SparkProcessBuilder._
 
+  val yarnClient = getYarnClient
+
+  def getYarnClient: YarnClient = YarnClient.createYarnClient

Review comment:
       @wForget, what about `createYarnClient`? @942011334, sorry to suggest a bit confusing method name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org