You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org> on 2007/08/13 12:01:43 UTC

[jira] Created: (TOMAHAWK-1082) t:messages does not put the class (error, info, fatal) to the li item when layout is "list"

t:messages does not put the class (error, info, fatal) to the li item when layout is "list"
-------------------------------------------------------------------------------------------

                 Key: TOMAHAWK-1082
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1082
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.6, 1.1.5, 1.1.7-SNAPSHOT
         Environment: myfaces 1.1.6-SNAPSHOT tomahawk 1.1.7-SNAPSHOT
            Reporter: nikolaos georgosoulos


This could easily be error on the myfaces core but since I'm here and since it is also produced with t:messages I report it here. When using the default layout (list) the class of the t:messages is passed into a span inside the li items. This is making the differentiation of errors quite more difficult. To my understanding the RI puts those classes in the li.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (TOMAHAWK-1082) t:messages does not put the class (error, info, fatal) to the li item when layout is "list"

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1082.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.9-SNAPSHOT
         Assignee: Leonardo Uribe

Fixed on both branches on myfaces core and tomahawk (related issue MYFACES-2139)

> t:messages does not put the class (error, info, fatal) to the li item when layout is "list"
> -------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1082
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1082
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Message(s)
>    Affects Versions: 1.1.5, 1.1.6, 1.1.7-SNAPSHOT
>         Environment: myfaces 1.1.6-SNAPSHOT tomahawk 1.1.7-SNAPSHOT
>            Reporter: nikolaos georgosoulos
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9-SNAPSHOT
>
>
> This could easily be error on the myfaces core but since I'm here and since it is also produced with t:messages I report it here. When using the default layout (list) the class of the t:messages is passed into a span inside the li items. This is making the differentiation of errors quite more difficult. To my understanding the RI puts those classes in the li.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TOMAHAWK-1082) t:messages does not put the class (error, info, fatal) to the li item when layout is "list"

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617893#action_12617893 ] 

Leonardo Uribe commented on TOMAHAWK-1082:
------------------------------------------

Right now this behavior is the default for myfaces core (because this is done on shared).

For be more specific:

MYFACES

<ul>
  <li><span class="errorClass">message</span></li>
</ul>

RI

<ul>
  <li class="errorClass">message</li>
</ul>

 The same applies with layout="table"

  If something changes for t:messages, h:messages changes too.

  But reading the documentation of h:message and h:messages, it seems that there is no reference about how this should be done.

  If a change is done here to do this as RI does, the actual applications using myfaces changes too (css style fixes could be needed). But it seems that the right way to do this is something like this:

<ul>
  <li class="errorClass"><span>message</span></li>
</ul>

 But I'm not sure about do this. Suggestions?

> t:messages does not put the class (error, info, fatal) to the li item when layout is "list"
> -------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1082
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1082
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Message(s)
>    Affects Versions: 1.1.5, 1.1.6, 1.1.7-SNAPSHOT
>         Environment: myfaces 1.1.6-SNAPSHOT tomahawk 1.1.7-SNAPSHOT
>            Reporter: nikolaos georgosoulos
>
> This could easily be error on the myfaces core but since I'm here and since it is also produced with t:messages I report it here. When using the default layout (list) the class of the t:messages is passed into a span inside the li items. This is making the differentiation of errors quite more difficult. To my understanding the RI puts those classes in the li.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.