[PR] [FLINK-40082][table] Watermark generated method `extractTimestamp` might invoke code throwinf exceptions [flink]

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin opened a new pull request, #28665:
URL: https://github.com/apache/flink/pull/28665

   
   ## What is the purpose of the change
   
   The problem with current implementation of `WatermarkGenerator` is that it generates method
   ```java
   public long extractTimestamp($ROW_DATA row) throws Exception {
         $generatedTimestampCode
   }
   ```
   Which under the hood might invoke `new String(byte[], Charset)` , in this case it has a checked exception `UnsupportedEncodingException`.
   
   The solution is to make it also throwing exceptions like `currentWatermark`
   
   ## Brief change log
   
   `WatermarkGeneratorCodeGenerator` and tests
   
   
   ## Verifying this change
   
   Test is included
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
   "Generated-by" line. See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
   AGENTS.md for the full guidance.
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name and Version]
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40082][table] Watermark generated method `extractTimestamp` might invoke code throwing exceptions [flink]

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin merged PR #28665:
URL: https://github.com/apache/flink/pull/28665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40082][table] Watermark generated method `extractTimestamp` might invoke code throwing exceptions [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #28665:
URL: https://github.com/apache/flink/pull/28665#issuecomment-4897075686

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "129f8bafbe8c9a673907ccdf960793bd76adc9ed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "129f8bafbe8c9a673907ccdf960793bd76adc9ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 129f8bafbe8c9a673907ccdf960793bd76adc9ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org