You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/19 14:00:01 UTC

[GitHub] [pulsar] huangdx0726 opened a new pull request #5897: [Issue 5887]Fix old version download link error

huangdx0726 opened a new pull request #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897
 
 
   Fix old version download link error
   
   Fixes #5887 
   
   ### Motivation
   
   Old version download link error
   
   ### Modifications
   
   Change the download link to https://archive.apache.org/dist/pulsar/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] huangdx0726 commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569405429
 
 
   run cpp tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569288260
 
 
   run cpp tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569177170
 
 
   run cpp tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] huangdx0726 commented on a change in pull request #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on a change in pull request #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#discussion_r361907787
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -178,13 +178,20 @@ for (v of versions) {
       `${v}`,
       binaryReleaseUrl(`${v}`),
       connectorReleaseUrl(`${v}`),
-      prestoPulsarReleaseUrl(`${latestVersion}`),
+      offloaderReleaseUrl(`${v}`),
+      prestoPulsarReleaseUrl(`${v}`),
       downloadPageUrl(),
       rpmReleaseUrl(`${v}`, ""),
       rpmReleaseUrl(`${v}`, "-debuginfo"),
       rpmReleaseUrl(`${v}`, "-devel"),
       debReleaseUrl(`${v}`, ""),
       debReleaseUrl(`${v}`, "-dev"),
+
+      rpmDistUrl(`${v}`, ""),
+      rpmDistUrl(`${v}`, "-debuginfo"),
+      rpmDistUrl(`${v}`, "-devel"),
+      debDistUrl(`${v}`, ""),
+      debDistUrl(`${v}`, "-dev")
 
 Review comment:
   I'v fixed it, PTAL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569564124
 
 
   run cpp tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on a change in pull request #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#discussion_r361564995
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -178,13 +178,20 @@ for (v of versions) {
       `${v}`,
       binaryReleaseUrl(`${v}`),
       connectorReleaseUrl(`${v}`),
-      prestoPulsarReleaseUrl(`${latestVersion}`),
+      offloaderReleaseUrl(`${v}`),
+      prestoPulsarReleaseUrl(`${v}`),
       downloadPageUrl(),
       rpmReleaseUrl(`${v}`, ""),
       rpmReleaseUrl(`${v}`, "-debuginfo"),
       rpmReleaseUrl(`${v}`, "-devel"),
       debReleaseUrl(`${v}`, ""),
       debReleaseUrl(`${v}`, "-dev"),
+
+      rpmDistUrl(`${v}`, ""),
+      rpmDistUrl(`${v}`, "-debuginfo"),
+      rpmDistUrl(`${v}`, "-devel"),
+      debDistUrl(`${v}`, ""),
+      debDistUrl(`${v}`, "-dev")
 
 Review comment:
   You can try:
   
   ```
         `${vWithoutIncubating}`,
         `${v}`,
         binaryReleaseUrl(`${v}`),
         connectorReleaseUrl(`${v}`),
         offloaderReleaseUrl(`${v}`),
         prestoPulsarReleaseUrl(`${v}`),
         downloadPageUrl(),
         rpmDistUrl(`${v}`, ""),
         rpmDistUrl(`${v}`, "-debuginfo"),
         rpmDistUrl(`${v}`, "-devel"),
         debDistUrl(`${v}`, ""),
         debDistUrl(`${v}`, "-dev"),
         rpmDistUrl(`${v}`, ""),
         rpmDistUrl(`${v}`, "-debuginfo"),
         rpmDistUrl(`${v}`, "-devel"),
         debDistUrl(`${v}`, ""),
         debDistUrl(`${v}`, "-dev")
   ```
   You can test the results by opening the html file `build/pulsar/docs/en/2.4.1/client-libraries-cpp/index.html` through the browser. I think this is correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569996398
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-569062756
 
 
   run cpp tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-570467797
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-573445379
 
 
   run java8 tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5897: [Issue 5887]Fix old version download link error

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#issuecomment-572178540
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services