You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/22 22:13:45 UTC

[GitHub] [couchdb] jjrodrig opened a new pull request #2593: Port changes.js test suite into elixir (sync with master)

jjrodrig opened a new pull request #2593: Port changes.js test suite into elixir (sync with master)
URL: https://github.com/apache/couchdb/pull/2593
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This PR ports the changes.js test suite into the elixir test suite which is already merged to master
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] garrensmith commented on issue #2593: Port changes.js test suite into elixir (sync with master)

Posted by GitBox <gi...@apache.org>.
garrensmith commented on issue #2593: Port changes.js test suite into elixir (sync with master)
URL: https://github.com/apache/couchdb/pull/2593#issuecomment-590747110
 
 
   Since this is already +1. I think you can just go ahead and merge into the the branch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jjrodrig commented on issue #2593: Port changes.js test suite into elixir (sync with master)

Posted by GitBox <gi...@apache.org>.
jjrodrig commented on issue #2593: Port changes.js test suite into elixir (sync with master)
URL: https://github.com/apache/couchdb/pull/2593#issuecomment-590747661
 
 
   Thanks @garrensmith 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jjrodrig merged pull request #2593: Port changes.js test suite into elixir (sync with master)

Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #2593: Port changes.js test suite into elixir (sync with master)
URL: https://github.com/apache/couchdb/pull/2593
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services