You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2022/11/10 14:47:38 UTC
[plc4x] branch develop updated: test(plc4j/bacnet): fixed tests
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
The following commit(s) were added to refs/heads/develop by this push:
new dfa9ec8b69 test(plc4j/bacnet): fixed tests
dfa9ec8b69 is described below
commit dfa9ec8b69580495658b468957181cbe0bc9f8dd
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Thu Nov 10 15:47:30 2022 +0100
test(plc4j/bacnet): fixed tests
---
.../java/org/apache/plc4x/java/bacnetip/RandomPackagesTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/plc4j/drivers/bacnet/src/test/java/org/apache/plc4x/java/bacnetip/RandomPackagesTest.java b/plc4j/drivers/bacnet/src/test/java/org/apache/plc4x/java/bacnetip/RandomPackagesTest.java
index 9250217628..19e4a8cb1c 100644
--- a/plc4j/drivers/bacnet/src/test/java/org/apache/plc4x/java/bacnetip/RandomPackagesTest.java
+++ b/plc4j/drivers/bacnet/src/test/java/org/apache/plc4x/java/bacnetip/RandomPackagesTest.java
@@ -643,7 +643,7 @@ public class RandomPackagesTest {
dump(bvlc);
NPDU npdu = ((BVLCOriginalUnicastNPDU) bvlc).getNpdu();
APDUSimpleAck apduSimpleAck = (APDUSimpleAck) npdu.getApdu();
- assertEquals(15, apduSimpleAck.getServiceChoice());
+ assertEquals(BACnetConfirmedServiceChoice.WRITE_PROPERTY, apduSimpleAck.getServiceChoice());
}),
DynamicTest.dynamicTest("No. 145-200 - Skip to 200 Misc packages",
() -> {
@@ -748,7 +748,7 @@ public class RandomPackagesTest {
NPDU npdu = ((BVLCOriginalUnicastNPDU) bvlc).getNpdu();
APDUSimpleAck apduSimpleAck = (APDUSimpleAck) npdu.getApdu();
assertEquals(119, apduSimpleAck.getOriginalInvokeId());
- assertEquals(2, apduSimpleAck.getServiceChoice());
+ assertEquals(BACnetConfirmedServiceChoice.CONFIRMED_EVENT_NOTIFICATION, apduSimpleAck.getServiceChoice());
}),
DynamicTest.dynamicTest("No. 3 - Confirmed-REQ confirmedEventNotification[120] event-enrollment,11 analog-input,1",
() -> {
@@ -805,7 +805,7 @@ public class RandomPackagesTest {
NPDU npdu = ((BVLCOriginalUnicastNPDU) bvlc).getNpdu();
APDUSimpleAck apduSimpleAck = (APDUSimpleAck) npdu.getApdu();
assertEquals(120, apduSimpleAck.getOriginalInvokeId());
- assertEquals(2, apduSimpleAck.getServiceChoice());
+ assertEquals(BACnetConfirmedServiceChoice.CONFIRMED_EVENT_NOTIFICATION, apduSimpleAck.getServiceChoice());
}),
DynamicTest.dynamicTest("No. 5 - Unconfirmed-REQ who-Is 140 140",
() -> {
@@ -941,7 +941,7 @@ public class RandomPackagesTest {
dump(bvlc);
NPDU npdu = ((BVLCOriginalUnicastNPDU) bvlc).getNpdu();
APDUSimpleAck apduSimpleAck = (APDUSimpleAck) npdu.getApdu();
- assertEquals((short) 5, apduSimpleAck.getServiceChoice());
+ assertEquals(BACnetConfirmedServiceChoice.SUBSCRIBE_COV, apduSimpleAck.getServiceChoice());
}),
DynamicTest.dynamicTest("No. 3 - Unconfirmed-REQ unconfirmedCOVNotification device,12345 binary-input,0 present-value status-flags",
() -> {