[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18166: [refactor](config) Delete the environment variable enable_vectorized_engine

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18166:
URL: https://github.com/apache/doris/pull/18166#discussion_r1156693709


##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -147,13 +147,19 @@ class OrcReader : public GenericReader {
     Status _decode_explicit_decimal_column(const std::string& col_name,
                                            const MutableColumnPtr& data_column,
                                            const DataTypePtr& data_type,
-                                           DecimalScaleParams& scale_params,
                                            orc::ColumnVectorBatch* cvb, size_t num_values) {
         OrcColumnType* data = dynamic_cast<OrcColumnType*>(cvb);
         if (data == nullptr) {
             return Status::InternalError("Wrong data type for colum '{}'", col_name);
         }
-        _init_decimal_converter<DecimalPrimitiveType>(data_type, scale_params, data->scale);
+        if (_decimal_scale_params_index >= _decimal_scale_params.size()) {
+            DecimalScaleParams temp_scale_params;
+            _init_decimal_converter<DecimalPrimitiveType>(data_type, temp_scale_params,
+                                                          data->scale);
+            _decimal_scale_params.emplace_back(std::move(temp_scale_params));

Review Comment:
   warning: std::move of the variable 'temp_scale_params' of the trivially-copyable type 'doris::vectorized::DecimalScaleParams' has no effect; remove std::move() [performance-move-const-arg]
   
   ```suggestion
               _decimal_scale_params.emplace_back(temp_scale_params);
   ```
   



##########
be/src/olap/column_predicate.h:
##########
@@ -121,6 +121,21 @@ struct PredicateTypeTraits {
     }
 };
 
+#define EVALUATE_BY_SELECTOR(EVALUATE_IMPL_WITH_NULL_MAP, EVALUATE_IMPL_WITHOUT_NULL_MAP) \

Review Comment:
   warning: macro is not used [clang-diagnostic-unused-macros]
   ```cpp
   #define EVALUATE_BY_SELECTOR(EVALUATE_IMPL_WITH_NULL_MAP, EVALUATE_IMPL_WITHOUT_NULL_MAP) \
           ^
   ```
   



##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -57,6 +57,15 @@ class PipScannerContext : public vectorized::ScannerContext {
             }
         }
         _current_used_bytes -= (*block)->allocated_bytes();
+        {
+            if (has_enough_space_in_blocks_queue()) {
+                std::unique_lock<std::mutex> l(_transfer_lock);
+                auto submit_st = _scanner_scheduler->submit(this);

Review Comment:
   warning: member access into incomplete type 'doris::vectorized::ScannerScheduler' [clang-diagnostic-error]
   ```cpp
                   auto submit_st = _scanner_scheduler->submit(this);
                                                      ^
   ```
   **be/src/runtime/exec_env.h:31:** forward declaration of 'doris::vectorized::ScannerScheduler'
   ```cpp
   class ScannerScheduler;
         ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org