You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/05 05:51:56 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2421: Make serialization pool in LogDispatcher static to reduece the number of pools

neuyilan commented on a change in pull request #2421:
URL: https://github.com/apache/iotdb/pull/2421#discussion_r551729836



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/LogDispatcher.java
##########
@@ -68,12 +69,13 @@
   private List<BlockingQueue<SendLogRequest>> nodeLogQueues =
       new ArrayList<>();
   private ExecutorService executorService;

Review comment:
       LGTM!
   only one question, why only change the _serializationService_ to use google's ThreadFactoryBuilder,
   Why not change the _executorService_? Is there any special thinking?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org