[jira] [Commented] (KAFKA-16836) Suspend reason of standby update listener is not correct

["Matthias J. Sax (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-16836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867079#comment-17867079 ] 

Matthias J. Sax commented on KAFKA-16836:
-----------------------------------------

[~cadonna] Given that state-updater is not enabled by default in 3.7, should we update affected version to 3.8?

> Suspend reason of standby update listener is not correct
> --------------------------------------------------------
>
>                 Key: KAFKA-16836
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16836
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 3.7.0
>            Reporter: Bruno Cadonna
>            Priority: Major
>
> The standby update listener introduced in KIP-988 takes a suspend reason in {{standbyUpdateListener.onUpdateSuspended()}}. The reason is determined in {{StoreChangelogReader#unregister()}} based on the state of the standby task [1]. However, {{unregister()}} is called in the state updater and in the state updater the state of the standby is always {{RUNNING}} since the state updater never changes the state of a task. So the standby task will always have {{PROMOTED}} as suspend reason, even if the standby is migrated.  
> [1] https://github.com/apache/kafka/blob/83110e2d425b49fed8ad5fdc6e93579423c73289/streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java#L1064



--
This message was sent by Atlassian Jira
(v8.20.10#820010)