You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by so...@apache.org on 2023/09/27 20:32:23 UTC

[superset] branch tooltip-copy-updates created (now 156b386fbd)

This is an automated email from the ASF dual-hosted git repository.

sophieyou pushed a change to branch tooltip-copy-updates
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 156b386fbd Update Explore tooltip copy

This branch includes the following new commits:

     new 156b386fbd Update Explore tooltip copy

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: Update Explore tooltip copy

Posted by so...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

sophieyou pushed a commit to branch tooltip-copy-updates
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 156b386fbd70e4f7ad1c8850082db2aefe90cce7
Author: yousoph <so...@gmail.com>
AuthorDate: Wed Sep 27 13:32:14 2023 -0700

    Update Explore tooltip copy
---
 .../src/shared-controls/dndControls.tsx            | 30 +++++++++++++---------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
index c915e8a89d..c711dcc212 100644
--- a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
+++ b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
@@ -71,8 +71,9 @@ export const dndGroupByControl: SharedControlConfig<
   default: [],
   includeTime: false,
   description: t(
-    'One or many columns to group by. High cardinality groupings should include a sort by metric ' +
-      'and series limit to limit the number of fetched and rendered series.',
+    'Dimensions contain qualitative values such as names, dates, or geographical data. ' +
+      'Use dimensions to categorize, segment, and reveal the details in your data. ' +
+      'Dimensions affect the level of detail in the view.',
   ),
   optionRenderer: (c: ColumnMeta) => <ColumnOption showType column={c} />,
   valueRenderer: (c: ColumnMeta) => <ColumnOption column={c} />,
@@ -108,7 +109,7 @@ export const dndGroupByControl: SharedControlConfig<
 export const dndColumnsControl: typeof dndGroupByControl = {
   ...dndGroupByControl,
   label: t('Columns'),
-  description: t('One or many columns to pivot as columns'),
+  description: t('Add dataset columns here to group the pivot table columns.'),
 };
 
 export const dndSeriesControl: typeof dndGroupByControl = {
@@ -118,8 +119,7 @@ export const dndSeriesControl: typeof dndGroupByControl = {
   default: null,
   description: t(
     'Defines the grouping of entities. ' +
-      'Each series is shown as a specific color on the chart and ' +
-      'has a legend toggle',
+      'Each series is represented by a specific color in the chart.',
   ),
 };
 
@@ -166,21 +166,27 @@ export const dndAdhocMetricsControl: SharedControlConfig<
     datasource,
     datasourceType: datasource?.type,
   }),
-  description: t('One or many metrics to display'),
+  description: t('Select one or many metrics to display. ' +
+                  'You can use an aggregation function on a column ' +
+                  'or write custom SQL to create a metric.'
+  ),
 };
 
 export const dndAdhocMetricControl: typeof dndAdhocMetricsControl = {
   ...dndAdhocMetricsControl,
   multi: false,
   label: t('Metric'),
-  description: t('Metric'),
+  description: t('Select a metric to display. ' +
+                  'You can use an aggregation function on a column ' +
+                  'or write custom SQL to create a metric.'
+  ),
 };
 
 export const dndAdhocMetricControl2: typeof dndAdhocMetricControl = {
   ...dndAdhocMetricControl,
   label: t('Right Axis Metric'),
   clearable: true,
-  description: t('Choose a metric for right axis'),
+  description: t('Select a metric to display on the right axis'),
 };
 
 export const dndSortByControl: SharedControlConfig<
@@ -190,8 +196,8 @@ export const dndSortByControl: SharedControlConfig<
   label: t('Sort by'),
   default: null,
   description: t(
-    'Metric used to define how the top series are sorted if a series or row limit is present. ' +
-      'If undefined reverts to the first metric (where appropriate).',
+    'This metric is used to define row selection criteria (how the rows are sorted) if a series or row limit is present. ' +
+      'If not defined, it reverts to the first metric (where appropriate).',
   ),
   mapStateToProps: ({ datasource }) => ({
     columns: datasource?.columns || [],
@@ -211,14 +217,14 @@ export const dndSizeControl: typeof dndAdhocMetricControl = {
 export const dndXControl: typeof dndAdhocMetricControl = {
   ...dndAdhocMetricControl,
   label: t('X Axis'),
-  description: t('Metric assigned to the [X] axis'),
+  description: t('The dataset column/metric that returns the values on your chart\'s x-axis.'),
   default: null,
 };
 
 export const dndYControl: typeof dndAdhocMetricControl = {
   ...dndAdhocMetricControl,
   label: t('Y Axis'),
-  description: t('Metric assigned to the [Y] axis'),
+  description: t('The dataset column/metric that returns the values on your chart\'s y-axis.'),
   default: null,
 };