You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 23:16:05 UTC

[GitHub] [airflow] Taragolis commented on pull request #28039: Migrate amazon provider hooks tests from `unittests` to `pytest`

Taragolis commented on PR #28039:
URL: https://github.com/apache/airflow/pull/28039#issuecomment-1334568914

   > nice. I noticed that on some `setup_method`s you added the optional `method` parameter without using it, while you skipped it on others. I think it'd be best to omit it wherever possible (i.e. probably everywhere in this case)
   
   That's funny but if `setup_method` or `teardown_method` decorated by `@mock.patсh` then should use signature (self, method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org