You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/03/05 08:40:09 UTC

[GitHub] [openmeetings] solomax commented on pull request #136: OPENMEETINGS-2585 Update StreamProcessor and KurentoHandler - moving method unrelated out of it

solomax commented on pull request #136:
URL: https://github.com/apache/openmeetings/pull/136#issuecomment-791260181


   Hello @sebawagner,
   
   it seems my English is not understandable
   
   I see no need in these changes at this stage
   
   additional constructor params are pure evil :( leading to the code like this: https://sonarcloud.io/project/issues?id=apache_openmeetings&resolved=false&rules=java%3AS107&types=CODE_SMELL
   
   I would once again suggest you to create some sort of cluster ready code (in OM or separate repo) before refactoring OM code ....


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org