[GitHub] [accumulo] ctubbsii commented on a change in pull request #2492: Add goal message to Fate

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2492:
URL: https://github.com/apache/accumulo/pull/2492#discussion_r806048913



##########
File path: core/src/main/java/org/apache/accumulo/fate/Fate.java
##########
@@ -268,18 +268,18 @@ public long startTransaction() {
 
   // start work in the transaction.. it is safe to call this
   // multiple times for a transaction... but it will only seed once
-  public void seedTransaction(long tid, Repo<T> repo, boolean autoCleanUp) {
+  public void seedTransaction(long tid, Repo<T> repo, boolean autoCleanUp, String goalMessage) {
     store.reserve(tid);
     try {
       if (store.getStatus(tid) == TStatus.NEW) {
         if (store.top(tid) == null) {
           try {
+            log.info("FATE TxId: {} {}", tid, goalMessage);

Review comment:
       I know users who do create and delete a lot of tables. :smiley_cat:
   
   The way I have thought about logging levels for server-side stuff is: INFO is best used for information about the server's status, like startup / shutdown, and major lifecycle events. DEBUG is useful for troubleshooting operations whose status would normally be observed by some other mechanism. Example: the fact that a table no longer appears in the table listing and a successful execution of the API for deleting a table, are normally sufficient to know that a table has been deleted, but debug logs can show the table being deleted on the server side. TRACE is useful for detailed information that we normally don't want to see, even for troubleshooting, because it's too noisy or not useful, unless we're specifically tracking down a bug in specific code that we are developing.
   
   Also, I think INFO and higher is stuff that you wouldn't mind seeing in STDOUT if you were to run the process in a terminal. After hours of running, you should still be able to scroll up to the first few lines of this output. DEBUG is stuff you'd want to go to a file for troubleshooting later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org