You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mario Ivankovits <ma...@ops.co.at> on 2008/07/06 12:04:09 UTC
current state of MYFACES-434
Hi!
What is the current state of MYFACES-434?
I tried to upgrade to the latest Tomahawk+Sandbox and now the
application fails to run properly as the TomahawkFacesContextWrapper
does the AddResource processing AND the ExtensionsFilter does the
AddResource processing. This results in having the scripts added twice
to the header which will result in non working dojo components.
Configuring the ExtensionsFilter to not cover the jsf requests will
result in the well known
"ExtensionsFilter not correctly configured. JSF mapping missing. JSF
pages not covered. Please see:
http://myfaces.apache.org/tomahawk/extensionsFilter.html
(java.lang.IllegalStateException)"
message.
So it seems we are half way, aren't we?
Did I do something wrong? If not, can we fix this?
Notice: I built Tomahawk & MyFaces from a fresh checkout (which was a
story itself as the 6-SNAPSHOT master pom couldn't be found).
Ciao,
Mario
Re: current state of MYFACES-434
Posted by Leonardo Uribe <lu...@gmail.com>.
On Mon, Jul 7, 2008 at 1:50 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>
>
> On Mon, Jul 7, 2008 at 2:31 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
>
>> Hi Leonardo,
>>
>> I tried to upgrade to the latest Tomahawk+Sandbox and now the
>>> application fails to run properly as the TomahawkFacesContextWrapper does
>>> the AddResource processing AND the ExtensionsFilter does the AddResource
>>> processing.
>>>
>>
>> The code in extension filter that do AddResource processing should be
>> commented (this was added to disable this feature before). But before do
>> that, we need to test several configurations of this feature
>> (DefaultAddResource, NonBufferingAddResource, if servlet or portlet
>> environment and other variations), because it could break old code.
>>
>> Ok, but it seems that Tomahawk head breaks every installation using
>> DefaultAddResource which makes it impossible to test new things.
>>
>> My workaround is to use DojoAddResource, but that is far from being nice.
>>
>> If you would like us to test this thing it would be great if you could
>> finish the work in ExtensionsFilter so that it really works as drop in
>> replacement.
>>
>
> Yes, I'll test this feature and complete it.
>
Hi
I have found the response wrapping error (very nasty and difficult to
understand). I have commited so right now and test several configurations
successfully.
regards
Leonardo Uribe
>
>
>>
>> Thanks!
>> Ciao,
>> Mario
>>
>
>
Re: current state of MYFACES-434
Posted by Leonardo Uribe <lu...@gmail.com>.
On Mon, Jul 7, 2008 at 2:31 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi Leonardo,
>
> I tried to upgrade to the latest Tomahawk+Sandbox and now the application
>> fails to run properly as the TomahawkFacesContextWrapper does the
>> AddResource processing AND the ExtensionsFilter does the AddResource
>> processing.
>>
>
> The code in extension filter that do AddResource processing should be
> commented (this was added to disable this feature before). But before do
> that, we need to test several configurations of this feature
> (DefaultAddResource, NonBufferingAddResource, if servlet or portlet
> environment and other variations), because it could break old code.
>
> Ok, but it seems that Tomahawk head breaks every installation using
> DefaultAddResource which makes it impossible to test new things.
>
> My workaround is to use DojoAddResource, but that is far from being nice.
>
> If you would like us to test this thing it would be great if you could
> finish the work in ExtensionsFilter so that it really works as drop in
> replacement.
>
Yes, I'll test this feature and complete it.
>
> Thanks!
> Ciao,
> Mario
>
Re: current state of MYFACES-434
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Leonardo,
>
> I tried to upgrade to the latest Tomahawk+Sandbox and now the
> application fails to run properly as the
> TomahawkFacesContextWrapper does the AddResource processing AND
> the ExtensionsFilter does the AddResource processing.
>
>
> The code in extension filter that do AddResource processing should be
> commented (this was added to disable this feature before). But before
> do that, we need to test several configurations of this feature
> (DefaultAddResource, NonBufferingAddResource, if servlet or portlet
> environment and other variations), because it could break old code.
Ok, but it seems that Tomahawk head breaks every installation using
DefaultAddResource which makes it impossible to test new things.
My workaround is to use DojoAddResource, but that is far from being nice.
If you would like us to test this thing it would be great if you could
finish the work in ExtensionsFilter so that it really works as drop in
replacement.
Thanks!
Ciao,
Mario
Re: current state of MYFACES-434
Posted by Leonardo Uribe <lu...@gmail.com>.
On Sun, Jul 6, 2008 at 5:04 AM, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
>
> What is the current state of MYFACES-434?
>
> I tried to upgrade to the latest Tomahawk+Sandbox and now the application
> fails to run properly as the TomahawkFacesContextWrapper does the
> AddResource processing AND the ExtensionsFilter does the AddResource
> processing. This results in having the scripts added twice to the header
> which will result in non working dojo components.
>
> Configuring the ExtensionsFilter to not cover the jsf requests will result
> in the well known
> "ExtensionsFilter not correctly configured. JSF mapping missing. JSF pages
> not covered. Please see:
> http://myfaces.apache.org/tomahawk/extensionsFilter.html(java.lang.IllegalStateException)"
> message.
>
The code in extension filter that do AddResource processing should be
commented (this was added to disable this feature before). But before do
that, we need to test several configurations of this feature
(DefaultAddResource, NonBufferingAddResource, if servlet or portlet
environment and other variations), because it could break old code.
Theorically the only things left are fileUpload support for portlets and do
this cleanup. TomahawkFacesContextWrapper has now implemented the critical
behaviors commented before about initialization params.
I'll add more comments about this topic soon.
>
> So it seems we are half way, aren't we?
> Did I do something wrong? If not, can we fix this?
>
> Notice: I built Tomahawk & MyFaces from a fresh checkout (which was a story
> itself as the 6-SNAPSHOT master pom couldn't be found).
>
> Ciao,
> Mario
>
>