You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/06 10:38:00 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #11934: [Transaction] add method to clear up transaction buffer snapshot
gaoran10 opened a new pull request #11934:
URL: https://github.com/apache/pulsar/pull/11934
### Motivation
Currently, the transaction buffer didn't support clear up the snapshot, if delete the topic the snapshot will not be deleted.
### Modifications
Clear up the transaction buffer snapshot when deleting the topic.
### Verifying this change
Add a test to verify the snapshot was clear up or not.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] doc-required
(If you need help on updating docs, create a doc issue)
- [x] no-need-doc
(Please explain why)
- [ ] doc
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11934: [Transaction] add method to clear up transaction buffer snapshot
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11934:
URL: https://github.com/apache/pulsar/pull/11934#discussion_r702883657
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TopicTransactionBufferRecoverTest.java
##########
@@ -403,4 +405,66 @@ private void testTopicTransactionBufferDeleteAbort() throws Exception {
}
assertTrue(exist);
}
+
+ @Test
+ public void clearTransactionBufferSnapshotTest() throws Exception {
+ String topic = NAMESPACE1 + "/tb-snapshot-delete-" + RandomUtils.nextInt();
+
+ @Cleanup
+ Producer<byte[]> producer = pulsarClient
+ .newProducer()
+ .topic(topic)
+ .sendTimeout(0, TimeUnit.SECONDS)
+ .create();
+
+ Transaction txn = pulsarClient.newTransaction()
+ .withTransactionTimeout(5, TimeUnit.SECONDS)
+ .build().get();
+ producer.newMessage(txn).value("test".getBytes()).sendAsync();
+ producer.newMessage(txn).value("test".getBytes()).sendAsync();
+ txn.commit().get();
+
+ // wait for take snapshot
+ Thread.sleep(1000 * 3);
Review comment:
Can we trigger the snapshot manually? this might introduce a flaky test in the CI enviroment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11934: [Transaction] add method to clear up transaction buffer snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11934:
URL: https://github.com/apache/pulsar/pull/11934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11934: [Transaction] add method to clear up transaction buffer snapshot
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11934:
URL: https://github.com/apache/pulsar/pull/11934#discussion_r702970026
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TopicTransactionBufferRecoverTest.java
##########
@@ -403,4 +405,66 @@ private void testTopicTransactionBufferDeleteAbort() throws Exception {
}
assertTrue(exist);
}
+
+ @Test
+ public void clearTransactionBufferSnapshotTest() throws Exception {
+ String topic = NAMESPACE1 + "/tb-snapshot-delete-" + RandomUtils.nextInt();
+
+ @Cleanup
+ Producer<byte[]> producer = pulsarClient
+ .newProducer()
+ .topic(topic)
+ .sendTimeout(0, TimeUnit.SECONDS)
+ .create();
+
+ Transaction txn = pulsarClient.newTransaction()
+ .withTransactionTimeout(5, TimeUnit.SECONDS)
+ .build().get();
+ producer.newMessage(txn).value("test".getBytes()).sendAsync();
+ producer.newMessage(txn).value("test".getBytes()).sendAsync();
+ txn.commit().get();
+
+ // wait for take snapshot
+ Thread.sleep(1000 * 3);
Review comment:
Ok, I'll fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org