You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by alexodus <gi...@git.apache.org> on 2014/10/27 13:19:05 UTC
[GitHub] thrift pull request: [python] remove useless semicolons
GitHub user alexodus opened a pull request:
https://github.com/apache/thrift/pull/250
[python] remove useless semicolons
removed useless semicolons in generated code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexodus/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit d843b361792eb3f7c68b3f17a0ac54c60bdb8137
Author: Alessandro Rossi <al...@gmail.com>
Date: 2014-10-27T12:11:48Z
remove useless semicolon
commit 970db92a0d34e52b48355c601a00fa628ea9646a
Author: Alessandro Rossi <al...@gmail.com>
Date: 2014-10-27T12:14:47Z
remove others useless semicolon
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [python] remove useless semicolons
Posted by cash <gi...@git.apache.org>.
Github user cash commented on the pull request:
https://github.com/apache/thrift/pull/250#issuecomment-63671408
This can be closed now because #276 was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [python] remove useless semicolons
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [python] remove useless semicolons
Posted by cash <gi...@git.apache.org>.
Github user cash commented on the pull request:
https://github.com/apache/thrift/pull/250#issuecomment-63977628
Reminder that this pull request can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [python] remove useless semicolons
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/250#issuecomment-72153651
@cash thanks for the pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] thrift pull request: [python] remove useless semicolons
Posted by Randy Abernethy <ra...@apache.org>.
alexodus,
Looks like a great patch, can you create an issue for it? Instructions here:
https://thrift.apache.org/docs/HowToContribute
If you did create an issue please point me at it, i could not locate
it by searching.
Best,
Randy
On Mon, Oct 27, 2014 at 5:19 AM, alexodus <gi...@git.apache.org> wrote:
> GitHub user alexodus opened a pull request:
>
> https://github.com/apache/thrift/pull/250
>
> [python] remove useless semicolons
>
> removed useless semicolons in generated code
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/alexodus/thrift master
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/thrift/pull/250.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #250
>
> ----
> commit d843b361792eb3f7c68b3f17a0ac54c60bdb8137
> Author: Alessandro Rossi <al...@gmail.com>
> Date: 2014-10-27T12:11:48Z
>
> remove useless semicolon
>
> commit 970db92a0d34e52b48355c601a00fa628ea9646a
> Author: Alessandro Rossi <al...@gmail.com>
> Date: 2014-10-27T12:14:47Z
>
> remove others useless semicolon
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] thrift pull request: [python] remove useless semicolons
Posted by cash <gi...@git.apache.org>.
Github user cash commented on the pull request:
https://github.com/apache/thrift/pull/250#issuecomment-63327204
Issue has been created: https://issues.apache.org/jira/browse/THRIFT-2834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---