You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/08 13:53:17 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #14625: Enable inner classes unit test for maven surefire plugin and fix failed test cases
sandynz opened a new pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625
Changes proposed in this pull request:
- Enable inner classes unit test for maven surefire plugin
- Fix `CosIdIntervalShardingAlgorithmTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #14625: Enable inner classes unit test for maven surefire plugin and ignore failed test cases for now
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625#issuecomment-1008028338
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14625](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62e14d5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/744df17a0dae8a0fb2c3aa4dd328b3f79ad37312?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (744df17) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14625 +/- ##
============================================
+ Coverage 59.63% 59.64% +0.01%
Complexity 1846 1846
============================================
Files 3029 3029
Lines 45121 45121
Branches 7628 7628
============================================
+ Hits 26907 26913 +6
+ Misses 16117 16111 -6
Partials 2097 2097
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/14625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...rding/algorithm/sharding/cosid/PropertiesUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/14625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2Nvc2lkL1Byb3BlcnRpZXNVdGlsLmphdmE=) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
| [...ithm/sharding/cosid/CosIdModShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/14625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2Nvc2lkL0Nvc0lkTW9kU2hhcmRpbmdBbGdvcml0aG0uamF2YQ==) | `90.00% <0.00%> (+70.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [744df17...62e14d5](https://codecov.io/gh/apache/shardingsphere/pull/14625?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #14625: Enable inner classes unit test for maven surefire plugin and fix failed test cases
Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625#issuecomment-1007998862
The solution is from https://github.com/junit-team/junit5/issues/1377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #14625: Enable inner classes unit test for maven surefire plugin and ignore failed test cases for now
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #14625: Enable inner classes unit test for maven surefire plugin and ignore failed test cases for now
Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625#issuecomment-1008218735
`CosIdIntervalShardingAlgorithmTest` is ignored in `mvn install` by default (refer to [surefire#excludes]( https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#excludes ) for more details).
After I enabled inner classes unit test and did a simple fixing, `CosIdIntervalShardingAlgorithmTest` still has failed cases in GitHub CI, more than I found on local test, refer to https://github.com/apache/shardingsphere/runs/4748280776?check_suite_focus=true for more details.
I've reverted `Collections.singleton` replacement and marked related test classes as `@Ignored` for now.
@Ahoo-Wang , could you help to fix these failed test cases of `CosIdIntervalShardingAlgorithmTest`? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Ahoo-Wang commented on pull request #14625: Enable inner classes unit test for maven surefire plugin and ignore failed test cases for now
Posted by GitBox <gi...@apache.org>.
Ahoo-Wang commented on pull request #14625:
URL: https://github.com/apache/shardingsphere/pull/14625#issuecomment-1008305076
> `CosIdIntervalShardingAlgorithmTest` is ignored in `mvn install` by default (refer to [surefire#excludes](https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#excludes) for more details).
>
> After I enabled inner classes unit test and did a simple fixing, `CosIdIntervalShardingAlgorithmTest` still has failed cases in GitHub CI, more than I found on local test, refer to https://github.com/apache/shardingsphere/runs/4748280776?check_suite_focus=true for more details.
>
> I've reverted `Collections.singleton` replacement and marked related test classes as `@Ignored` for now.
>
> @Ahoo-Wang , could you help to fix these failed test cases of `CosIdIntervalShardingAlgorithmTest`? Thanks.
YES,I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org