[GitHub] [echarts-doc] gitforhlp commented on pull request #279: delete hightlight and downplay doc

[GitBox <gi...@apache.org>]

gitforhlp commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229886807

   
   
   
   > I was confused because `highlight` is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90
   > 
   > It should be.
   > 
   > ```ts
   > deprecateReplaceLog('sunburstHighlight', 'highlight');
   > ```
   > 
   > So we should change this warning log instead of changing the doc
   
   It is stated in the V5 document that this is discarded in the sunrise chart, and it is not a code problem
   [](https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api)
   ![Uploading image.png…]()
   please review again
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org