[GitHub] [trafficserver] maskit commented on a diff in pull request #9877: Do not add content-length for status 204 cache

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9877:
URL: https://github.com/apache/trafficserver/pull/9877#discussion_r1235794525


##########
proxy/http/HttpTransact.cc:
##########
@@ -6748,7 +6748,9 @@ HttpTransact::handle_content_length_header(State *s, HTTPHdr *header, HTTPHdr *b
         change_response_header_because_of_range_request(s, header);
         s->hdr_info.trust_response_cl = true;
       } else {
-        header->set_content_length(cl);
+        if (!(s->source == SOURCE_CACHE && header->status_get() == HTTP_STATUS_NO_CONTENT)) {

Review Comment:
   Can you tell me why `s->source == SOURCE_CACHE` is needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org