You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/06/02 09:17:46 UTC

Review Request 34928: SQOOP-2384: Remove source from binary distribution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34928/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

The current binary distribution will also package source code, actually there is already a profile "source" which is responsible for package source code.


Diffs
-----

  dist/pom.xml f1d671e 

Diff: https://reviews.apache.org/r/34928/diff/


Testing
-------


Thanks,

Dian Fu


Re: Review Request 34928: SQOOP-2384: SQOOP2: Remove source from binary distribution

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34928/#review88757
-----------------------------------------------------------



dist/pom.xml 
<https://reviews.apache.org/r/34928/#comment141342>

    Might want to copy over LICENSE, CHANGELOG, README, NOTICES, etc. The LICENSE and NOTICES files are needed for ASLv2.


- Abraham Elmahrek


On June 4, 2015, 2:09 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34928/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 2:09 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The current binary distribution will also package source code, actually there is already a profile "source" which is responsible for package source code.
> 
> 
> Diffs
> -----
> 
>   dist/pom.xml f1d671e 
> 
> Diff: https://reviews.apache.org/r/34928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Re: Review Request 34928: SQOOP-2384: SQOOP2: Remove source from binary distribution

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34928/#review92660
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On June 25, 2015, 1:58 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34928/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 1:58 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The current binary distribution will also package source code, actually there is already a profile "source" which is responsible for package source code.
> 
> 
> Diffs
> -----
> 
>   dist/pom.xml f1d671e 
> 
> Diff: https://reviews.apache.org/r/34928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Re: Review Request 34928: SQOOP-2384: SQOOP2: Remove source from binary distribution

Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34928/
-----------------------------------------------------------

(Updated June 25, 2015, 1:58 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

The current binary distribution will also package source code, actually there is already a profile "source" which is responsible for package source code.


Diffs (updated)
-----

  dist/pom.xml f1d671e 

Diff: https://reviews.apache.org/r/34928/diff/


Testing
-------


Thanks,

Dian Fu


Re: Review Request 34928: SQOOP-2384: SQOOP2: Remove source from binary distribution

Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34928/
-----------------------------------------------------------

(Updated June 4, 2015, 2:09 a.m.)


Review request for Sqoop.


Summary (updated)
-----------------

SQOOP-2384: SQOOP2: Remove source from binary distribution


Repository: sqoop-sqoop2


Description
-------

The current binary distribution will also package source code, actually there is already a profile "source" which is responsible for package source code.


Diffs
-----

  dist/pom.xml f1d671e 

Diff: https://reviews.apache.org/r/34928/diff/


Testing
-------


Thanks,

Dian Fu