You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2016/05/12 06:06:24 UTC
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/13071
[SPARK-15281][PySpark][ML][TRIVIAL] Add impurity param to GBTRegressor
## What changes were proposed in this pull request?
Add impurity param to GBTRegressor and mark the of the models & regressors in regression.py as experimental to match Scaladoc.
## How was this patch tested?
Added default value to init, tested with unit/doc tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark SPARK-15281-GBTRegressor-impurity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13071.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13071
----
commit 7213681f6f0b557b170a159dacee8fc06453d53c
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-05-12T00:00:58Z
Add impurity param to GBTRegressor, also mark as experimental and other models that have been first pass over as experimental
commit db9c4aa6a7b0554ec2209c4bba2194bae38647d6
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-05-12T00:03:11Z
Mark the rest of the models and regressors as experimental to match Scala
commit 2b4f3eb539524e48f5cdac38407466fa036bf8ca
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-05-12T01:41:50Z
more doc, fix switch
commit 274400dd0f9d183935186b1b324f17db0367e183
Author: Holden Karau <ho...@us.ibm.com>
Date: 2016-05-12T06:05:30Z
Add Experimental note to LinearRegressionModel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13071#issuecomment-218669753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58453/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13071#issuecomment-218668299
**[Test build #58453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58453/consoleFull)** for PR 13071 at commit [`274400d`](https://github.com/apache/spark/commit/274400dd0f9d183935186b1b324f17db0367e183).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13071#issuecomment-218679204
LGTM. Merged to master and branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13071#issuecomment-218669750
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13071
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13071#issuecomment-218669684
**[Test build #58453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58453/consoleFull)** for PR 13071 at commit [`274400d`](https://github.com/apache/spark/commit/274400dd0f9d183935186b1b324f17db0367e183).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org