[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #104: plugins.database.py callers do not discriminate real errors

[GitBox <gi...@apache.org>]

sebbASF opened a new issue #104:
URL: https://github.com/apache/incubator-ponymail-foal/issues/104


   Callers of the plugins.database methods generally treat all errors the same as a 404.
   
   This means that more serious errors can be missed.
   
   Many ES commands always return a successful HTTP status, so any errors should be regarded as fatal.
   
   For the few (e.g. GET) that can return a 4xx status, this should be explicitly checked, rather than assuming any error is 404.
   
   In classic PonyMail, this was done by the elastic.lua interface, so callers did not have to concern themselves with this ES-specific detail.
   
   I think it would make sense to do the checks at a lower level than currently, so the main logic does not have to concern itself with such detail.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org