You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Avik Sengupta <av...@apache.org> on 2003/07/25 10:24:06 UTC

Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel TestHSSFHeaderFooter.java

Dont you want to commit these (and the getformat bug) to HEAD as well?

On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
> slaubach    2003/07/24 11:42:46
> 
>   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
>                         Sheet.java
>   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
>                         EmbeddedChartHeaderTest.xls
>                src/testcases/org/apache/poi/hssf/usermodel Tag:
>                         REL_2_BRANCH TestHSSFHeaderFooter.java
>   Log:
>   Applied the pertinent patch for bug #21439 by Paul Pound to get the header/footer from the sheet and not a chart.
>   
>   Revision  Changes    Path
>   No                   revision
>   
>   
>   No                   revision
>   
>   
>   1.31.2.3  +2 -2      jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
>   
>   Index: Sheet.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
>   retrieving revision 1.31.2.2
>   retrieving revision 1.31.2.3
>   diff -u -r1.31.2.2 -r1.31.2.3
>   --- Sheet.java	27 Jun 2003 23:21:17 -0000	1.31.2.2
>   +++ Sheet.java	24 Jul 2003 18:42:45 -0000	1.31.2.3
>   @@ -249,11 +249,11 @@
>                {
>                    retval.printGridlines = (PrintGridlinesRecord) rec;
>                }
>   -            else if ( rec.getSid() == HeaderRecord.sid )
>   +            else if ( rec.getSid() == HeaderRecord.sid && bofEofNestingLevel == 1)
>                {
>                    retval.header = (HeaderRecord) rec;
>                }
>   -            else if ( rec.getSid() == FooterRecord.sid )
>   +            else if ( rec.getSid() == FooterRecord.sid && bofEofNestingLevel == 1)
>                {
>                    retval.footer = (FooterRecord) rec;
>                }
>   
>   
>   
>   No                   revision
>   
>   
>   No                   revision
>   
>   
>   1.1.2.1   +0 -0      jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.xls
>   
>   	<<Binary file>>
>   
>   
>   No                   revision
>   
>   
>   No                   revision
>   
>   
>   1.1.2.1   +0 -0      jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java
>   
>   Index: TestHSSFHeaderFooter.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java,v
>   retrieving revision 1.1
>   retrieving revision 1.1.2.1
>   diff -u -r1.1 -r1.1.2.1
>   
>   
>   
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> 
-- 
Avik Sengupta <av...@apache.org>


Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHeade rFooter.java

Posted by Avik Sengupta <av...@apache.org>.
yesssss saah, will do!   :)

But seriously, its the highest on my list.. tonight or tomorrow morning.
On Fri, 2003-07-25 at 18:05, Andrew C. Oliver wrote:
> Do it.
> 
> On 7/25/03 8:02 AM, "Avik Sengupta" <av...@apache.org> wrote:
> 
> > Ok, just asking, sorry to bother...:)
> > I am slightly paranoid at the moment since i have a backlog of stuff to
> > commit to HEAD :((
> > 
> > -
> > avik
> > 
> > On Fri, 2003-07-25 at 17:17, Shawn Laubach wrote:
> >> I did that a week and a half ago.  As for the getFormat, I was going to add
> >> that with my new margin code as soon as Andy says it won't mess him up.  He
> >> said "Give it a few days just so that we don¹t step on each others code...
> >> I'm
> >> doing the performance merge." and I asked him to email me when it was OK.
> >> 
> >> Shawn
> >> 
> >> -----Original Message-----
> >> From: Avik Sengupta [mailto:avik@apache.org]
> >> Sent: Friday, July 25, 2003 3:24 AM
> >> To: POI Developers List
> >> Subject: Re: cvs
> >> commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHe
> >> aderFooter.java
> >> 
> >> 
> >> Dont you want to commit these (and the getformat bug) to HEAD as well?
> >> 
> >> On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
> >>> slaubach    2003/07/24 11:42:46
> >>> 
> >>>   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
> >>>                         Sheet.java
> >>>   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
> >>>                         EmbeddedChartHeaderTest.xls
> >>>                src/testcases/org/apache/poi/hssf/usermodel Tag:
> >>>                         REL_2_BRANCH TestHSSFHeaderFooter.java
> >>>   Log:
> >>>   Applied the pertinent patch for bug #21439 by Paul Pound to get the
> >> header/footer from the sheet and not a chart.
> >>> 
> >>>   Revision  Changes    Path
> >>>   No                   revision
> >>> 
> >>> 
> >>>   No                   revision
> >>> 
> >>> 
> >>>   1.31.2.3  +2 -2
> >> jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
> >>> 
> >>>   Index: Sheet.java
> >>>   ===================================================================
> >>>   RCS file:
> >> /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
> >>>   retrieving revision 1.31.2.2
> >>>   retrieving revision 1.31.2.3
> >>>   diff -u -r1.31.2.2 -r1.31.2.3
> >>>   --- Sheet.java    27 Jun 2003 23:21:17 -0000    1.31.2.2
> >>>   +++ Sheet.java    24 Jul 2003 18:42:45 -0000    1.31.2.3
> >>>   @@ -249,11 +249,11 @@
> >>>                {
> >>>                    retval.printGridlines = (PrintGridlinesRecord) rec;
> >>>                }
> >>>   -            else if ( rec.getSid() == HeaderRecord.sid )
> >>>   +            else if ( rec.getSid() == HeaderRecord.sid &&
> >> bofEofNestingLevel == 1)
> >>>                {
> >>>                    retval.header = (HeaderRecord) rec;
> >>>                }
> >>>   -            else if ( rec.getSid() == FooterRecord.sid )
> >>>   +            else if ( rec.getSid() == FooterRecord.sid &&
> >> bofEofNestingLevel == 1)
> >>>                {
> >>>                    retval.footer = (FooterRecord) rec;
> >>>                }
> >>> 
> >>> 
> >>> 
> >>>   No                   revision
> >>> 
> >>> 
> >>>   No                   revision
> >>> 
> >>> 
> >>>   1.1.2.1   +0 -0
> >> jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.x
> >> ls
> >>> 
> >>> <<Binary file>>
> >>> 
> >>> 
> >>>   No                   revision
> >>> 
> >>> 
> >>>   No                   revision
> >>> 
> >>> 
> >>>   1.1.2.1   +0 -0
> >> jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter
> >> .java
> >>> 
> >>>   Index: TestHSSFHeaderFooter.java
> >>>   ===================================================================
> >>>   RCS file:
> >> /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHe
> >> aderFooter.java,v
> >>>   retrieving revision 1.1
> >>>   retrieving revision 1.1.2.1
> >>>   diff -u -r1.1 -r1.1.2.1
> >>> 
> >>> 
> >>> 
> >>> 
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> >>> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> >>> 
> >> --
> >> Avik Sengupta <av...@apache.org>
> >> 
> >> 
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> >> 
> >> 
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> >> 
-- 
Avik Sengupta <av...@apache.org>


Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHeade rFooter.java

Posted by "Andrew C. Oliver" <ac...@apache.org>.
Do it.

On 7/25/03 8:02 AM, "Avik Sengupta" <av...@apache.org> wrote:

> Ok, just asking, sorry to bother...:)
> I am slightly paranoid at the moment since i have a backlog of stuff to
> commit to HEAD :((
> 
> -
> avik
> 
> On Fri, 2003-07-25 at 17:17, Shawn Laubach wrote:
>> I did that a week and a half ago.  As for the getFormat, I was going to add
>> that with my new margin code as soon as Andy says it won't mess him up.  He
>> said "Give it a few days just so that we don¹t step on each others code...
>> I'm
>> doing the performance merge." and I asked him to email me when it was OK.
>> 
>> Shawn
>> 
>> -----Original Message-----
>> From: Avik Sengupta [mailto:avik@apache.org]
>> Sent: Friday, July 25, 2003 3:24 AM
>> To: POI Developers List
>> Subject: Re: cvs
>> commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHe
>> aderFooter.java
>> 
>> 
>> Dont you want to commit these (and the getformat bug) to HEAD as well?
>> 
>> On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
>>> slaubach    2003/07/24 11:42:46
>>> 
>>>   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
>>>                         Sheet.java
>>>   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
>>>                         EmbeddedChartHeaderTest.xls
>>>                src/testcases/org/apache/poi/hssf/usermodel Tag:
>>>                         REL_2_BRANCH TestHSSFHeaderFooter.java
>>>   Log:
>>>   Applied the pertinent patch for bug #21439 by Paul Pound to get the
>> header/footer from the sheet and not a chart.
>>> 
>>>   Revision  Changes    Path
>>>   No                   revision
>>> 
>>> 
>>>   No                   revision
>>> 
>>> 
>>>   1.31.2.3  +2 -2
>> jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
>>> 
>>>   Index: Sheet.java
>>>   ===================================================================
>>>   RCS file:
>> /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
>>>   retrieving revision 1.31.2.2
>>>   retrieving revision 1.31.2.3
>>>   diff -u -r1.31.2.2 -r1.31.2.3
>>>   --- Sheet.java    27 Jun 2003 23:21:17 -0000    1.31.2.2
>>>   +++ Sheet.java    24 Jul 2003 18:42:45 -0000    1.31.2.3
>>>   @@ -249,11 +249,11 @@
>>>                {
>>>                    retval.printGridlines = (PrintGridlinesRecord) rec;
>>>                }
>>>   -            else if ( rec.getSid() == HeaderRecord.sid )
>>>   +            else if ( rec.getSid() == HeaderRecord.sid &&
>> bofEofNestingLevel == 1)
>>>                {
>>>                    retval.header = (HeaderRecord) rec;
>>>                }
>>>   -            else if ( rec.getSid() == FooterRecord.sid )
>>>   +            else if ( rec.getSid() == FooterRecord.sid &&
>> bofEofNestingLevel == 1)
>>>                {
>>>                    retval.footer = (FooterRecord) rec;
>>>                }
>>> 
>>> 
>>> 
>>>   No                   revision
>>> 
>>> 
>>>   No                   revision
>>> 
>>> 
>>>   1.1.2.1   +0 -0
>> jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.x
>> ls
>>> 
>>> <<Binary file>>
>>> 
>>> 
>>>   No                   revision
>>> 
>>> 
>>>   No                   revision
>>> 
>>> 
>>>   1.1.2.1   +0 -0
>> jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter
>> .java
>>> 
>>>   Index: TestHSSFHeaderFooter.java
>>>   ===================================================================
>>>   RCS file:
>> /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHe
>> aderFooter.java,v
>>>   retrieving revision 1.1
>>>   retrieving revision 1.1.2.1
>>>   diff -u -r1.1 -r1.1.2.1
>>> 
>>> 
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>>> 
>> --
>> Avik Sengupta <av...@apache.org>
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>> 

-- 
Andrew C. Oliver
http://www.superlinksoftware.com/poi.jsp
Custom enhancements and Commercial Implementation for Jakarta POI

http://jakarta.apache.org/poi
For Java and Excel, Got POI?


RE: cvs commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHeaderFooter.java

Posted by Avik Sengupta <av...@apache.org>.
Ok, just asking, sorry to bother...:)
I am slightly paranoid at the moment since i have a backlog of stuff to
commit to HEAD :((

-
avik

On Fri, 2003-07-25 at 17:17, Shawn Laubach wrote:
> I did that a week and a half ago.  As for the getFormat, I was going to add
> that with my new margin code as soon as Andy says it won't mess him up.  He
> said "Give it a few days just so that we don¹t step on each others code...
> I'm
> doing the performance merge." and I asked him to email me when it was OK.
> 
> Shawn
> 
> -----Original Message-----
> From: Avik Sengupta [mailto:avik@apache.org]
> Sent: Friday, July 25, 2003 3:24 AM
> To: POI Developers List
> Subject: Re: cvs
> commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHe
> aderFooter.java
> 
> 
> Dont you want to commit these (and the getformat bug) to HEAD as well?
> 
> On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
> > slaubach    2003/07/24 11:42:46
> >
> >   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
> >                         Sheet.java
> >   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
> >                         EmbeddedChartHeaderTest.xls
> >                src/testcases/org/apache/poi/hssf/usermodel Tag:
> >                         REL_2_BRANCH TestHSSFHeaderFooter.java
> >   Log:
> >   Applied the pertinent patch for bug #21439 by Paul Pound to get the
> header/footer from the sheet and not a chart.
> >
> >   Revision  Changes    Path
> >   No                   revision
> >
> >
> >   No                   revision
> >
> >
> >   1.31.2.3  +2 -2
> jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
> >
> >   Index: Sheet.java
> >   ===================================================================
> >   RCS file:
> /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
> >   retrieving revision 1.31.2.2
> >   retrieving revision 1.31.2.3
> >   diff -u -r1.31.2.2 -r1.31.2.3
> >   --- Sheet.java	27 Jun 2003 23:21:17 -0000	1.31.2.2
> >   +++ Sheet.java	24 Jul 2003 18:42:45 -0000	1.31.2.3
> >   @@ -249,11 +249,11 @@
> >                {
> >                    retval.printGridlines = (PrintGridlinesRecord) rec;
> >                }
> >   -            else if ( rec.getSid() == HeaderRecord.sid )
> >   +            else if ( rec.getSid() == HeaderRecord.sid &&
> bofEofNestingLevel == 1)
> >                {
> >                    retval.header = (HeaderRecord) rec;
> >                }
> >   -            else if ( rec.getSid() == FooterRecord.sid )
> >   +            else if ( rec.getSid() == FooterRecord.sid &&
> bofEofNestingLevel == 1)
> >                {
> >                    retval.footer = (FooterRecord) rec;
> >                }
> >
> >
> >
> >   No                   revision
> >
> >
> >   No                   revision
> >
> >
> >   1.1.2.1   +0 -0
> jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.x
> ls
> >
> >   	<<Binary file>>
> >
> >
> >   No                   revision
> >
> >
> >   No                   revision
> >
> >
> >   1.1.2.1   +0 -0
> jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter
> .java
> >
> >   Index: TestHSSFHeaderFooter.java
> >   ===================================================================
> >   RCS file:
> /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHe
> aderFooter.java,v
> >   retrieving revision 1.1
> >   retrieving revision 1.1.2.1
> >   diff -u -r1.1 -r1.1.2.1
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> >
> --
> Avik Sengupta <av...@apache.org>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> 
-- 
Avik Sengupta <av...@apache.org>


Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHeade rFooter.java

Posted by "Andrew C. Oliver" <ac...@apache.org>.
Oh, my bad.  I'm done in the head for now...go for it.


On 7/25/03 7:47 AM, "Shawn Laubach" <sh...@cox.net> wrote:

> I did that a week and a half ago.  As for the getFormat, I was going to add
> that with my new margin code as soon as Andy says it won't mess him up.  He
> said "Give it a few days just so that we don¹t step on each others code...
> I'm
> doing the performance merge." and I asked him to email me when it was OK.
> 
> Shawn
> 
> -----Original Message-----
> From: Avik Sengupta [mailto:avik@apache.org]
> Sent: Friday, July 25, 2003 3:24 AM
> To: POI Developers List
> Subject: Re: cvs
> commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHe
> aderFooter.java
> 
> 
> Dont you want to commit these (and the getformat bug) to HEAD as well?
> 
> On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
>> slaubach    2003/07/24 11:42:46
>> 
>>   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
>>                         Sheet.java
>>   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
>>                         EmbeddedChartHeaderTest.xls
>>                src/testcases/org/apache/poi/hssf/usermodel Tag:
>>                         REL_2_BRANCH TestHSSFHeaderFooter.java
>>   Log:
>>   Applied the pertinent patch for bug #21439 by Paul Pound to get the
> header/footer from the sheet and not a chart.
>> 
>>   Revision  Changes    Path
>>   No                   revision
>> 
>> 
>>   No                   revision
>> 
>> 
>>   1.31.2.3  +2 -2
> jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
>> 
>>   Index: Sheet.java
>>   ===================================================================
>>   RCS file:
> /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
>>   retrieving revision 1.31.2.2
>>   retrieving revision 1.31.2.3
>>   diff -u -r1.31.2.2 -r1.31.2.3
>>   --- Sheet.java    27 Jun 2003 23:21:17 -0000    1.31.2.2
>>   +++ Sheet.java    24 Jul 2003 18:42:45 -0000    1.31.2.3
>>   @@ -249,11 +249,11 @@
>>                {
>>                    retval.printGridlines = (PrintGridlinesRecord) rec;
>>                }
>>   -            else if ( rec.getSid() == HeaderRecord.sid )
>>   +            else if ( rec.getSid() == HeaderRecord.sid &&
> bofEofNestingLevel == 1)
>>                {
>>                    retval.header = (HeaderRecord) rec;
>>                }
>>   -            else if ( rec.getSid() == FooterRecord.sid )
>>   +            else if ( rec.getSid() == FooterRecord.sid &&
> bofEofNestingLevel == 1)
>>                {
>>                    retval.footer = (FooterRecord) rec;
>>                }
>> 
>> 
>> 
>>   No                   revision
>> 
>> 
>>   No                   revision
>> 
>> 
>>   1.1.2.1   +0 -0
> jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.x
> ls
>> 
>> <<Binary file>>
>> 
>> 
>>   No                   revision
>> 
>> 
>>   No                   revision
>> 
>> 
>>   1.1.2.1   +0 -0
> jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter
> .java
>> 
>>   Index: TestHSSFHeaderFooter.java
>>   ===================================================================
>>   RCS file:
> /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHe
> aderFooter.java,v
>>   retrieving revision 1.1
>>   retrieving revision 1.1.2.1
>>   diff -u -r1.1 -r1.1.2.1
>> 
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>> 
> --
> Avik Sengupta <av...@apache.org>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> 

-- 
Andrew C. Oliver
http://www.superlinksoftware.com/poi.jsp
Custom enhancements and Commercial Implementation for Jakarta POI

http://jakarta.apache.org/poi
For Java and Excel, Got POI?


RE: cvs commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHeaderFooter.java

Posted by Shawn Laubach <sh...@cox.net>.
I did that a week and a half ago.  As for the getFormat, I was going to add
that with my new margin code as soon as Andy says it won't mess him up.  He
said "Give it a few days just so that we don¹t step on each others code...
I'm
doing the performance merge." and I asked him to email me when it was OK.

Shawn

-----Original Message-----
From: Avik Sengupta [mailto:avik@apache.org]
Sent: Friday, July 25, 2003 3:24 AM
To: POI Developers List
Subject: Re: cvs
commit:jakarta-poi/src/testcases/org/apache/poi/hssf/usermodelTestHSSFHe
aderFooter.java


Dont you want to commit these (and the getformat bug) to HEAD as well?

On Fri, 2003-07-25 at 00:12, slaubach@apache.org wrote:
> slaubach    2003/07/24 11:42:46
>
>   Modified:    src/java/org/apache/poi/hssf/model Tag: REL_2_BRANCH
>                         Sheet.java
>   Added:       src/testcases/org/apache/poi/hssf/data Tag: REL_2_BRANCH
>                         EmbeddedChartHeaderTest.xls
>                src/testcases/org/apache/poi/hssf/usermodel Tag:
>                         REL_2_BRANCH TestHSSFHeaderFooter.java
>   Log:
>   Applied the pertinent patch for bug #21439 by Paul Pound to get the
header/footer from the sheet and not a chart.
>
>   Revision  Changes    Path
>   No                   revision
>
>
>   No                   revision
>
>
>   1.31.2.3  +2 -2
jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java
>
>   Index: Sheet.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Sheet.java,v
>   retrieving revision 1.31.2.2
>   retrieving revision 1.31.2.3
>   diff -u -r1.31.2.2 -r1.31.2.3
>   --- Sheet.java	27 Jun 2003 23:21:17 -0000	1.31.2.2
>   +++ Sheet.java	24 Jul 2003 18:42:45 -0000	1.31.2.3
>   @@ -249,11 +249,11 @@
>                {
>                    retval.printGridlines = (PrintGridlinesRecord) rec;
>                }
>   -            else if ( rec.getSid() == HeaderRecord.sid )
>   +            else if ( rec.getSid() == HeaderRecord.sid &&
bofEofNestingLevel == 1)
>                {
>                    retval.header = (HeaderRecord) rec;
>                }
>   -            else if ( rec.getSid() == FooterRecord.sid )
>   +            else if ( rec.getSid() == FooterRecord.sid &&
bofEofNestingLevel == 1)
>                {
>                    retval.footer = (FooterRecord) rec;
>                }
>
>
>
>   No                   revision
>
>
>   No                   revision
>
>
>   1.1.2.1   +0 -0
jakarta-poi/src/testcases/org/apache/poi/hssf/data/EmbeddedChartHeaderTest.x
ls
>
>   	<<Binary file>>
>
>
>   No                   revision
>
>
>   No                   revision
>
>
>   1.1.2.1   +0 -0
jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter
.java
>
>   Index: TestHSSFHeaderFooter.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHe
aderFooter.java,v
>   retrieving revision 1.1
>   retrieving revision 1.1.2.1
>   diff -u -r1.1 -r1.1.2.1
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>
--
Avik Sengupta <av...@apache.org>


---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: poi-dev-help@jakarta.apache.org