You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/15 17:13:01 UTC

[GitHub] [tvm] nverke commented on a diff in pull request #12795: [Hexagon] Add debug option to hexagon pytest

nverke commented on code in PR #12795:
URL: https://github.com/apache/tvm/pull/12795#discussion_r972244389


##########
python/tvm/contrib/hexagon/pytest_plugin.py:
##########
@@ -246,8 +247,10 @@ def hexagon_launcher(
         yield launcher
     finally:
         if android_serial_num == ["simulator"]:
-            launcher.stop_server()
-        launcher.cleanup_directory()
+            launcher.stop_server(cleanup=(not hexagon_debug))
+
+        if not hexagon_debug:
+            launcher.cleanup_directory()

Review Comment:
   Are we calling cleanup multiple times? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org