You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by ni...@apache.org on 2004/12/11 16:59:53 UTC

svn commit: r111601 - /incubator/directory/kerberos/trunk/gump.xml

Author: niclas
Date: Sat Dec 11 07:59:52 2004
New Revision: 111601

URL: http://svn.apache.org/viewcvs?view=rev&rev=111601
Log:
More Gump stuff.
Modified:
   incubator/directory/kerberos/trunk/gump.xml

Modified: incubator/directory/kerberos/trunk/gump.xml
Url: http://svn.apache.org/viewcvs/incubator/directory/kerberos/trunk/gump.xml?view=diff&rev=111601&p1=incubator/directory/kerberos/trunk/gump.xml&r1=111600&p2=incubator/directory/kerberos/trunk/gump.xml&r2=111601
==============================================================================
--- incubator/directory/kerberos/trunk/gump.xml	(original)
+++ incubator/directory/kerberos/trunk/gump.xml	Sat Dec 11 07:59:52 2004
@@ -38,8 +38,8 @@
       <property name="maven.final.name" value="eve-kerberos-@@DATE@@"/>
     </maven>
 
-    <depend property="maven.regexp.jar" project="jakarta-regexp">
-    <depend property="maven.oro.jar" project="jakarta-oro">
+    <depend property="maven.regexp.jar" project="jakarta-regexp" id="regexp" >
+    <depend property="maven.oro.jar" project="jakarta-oro" id="oro" >
     <depend project="commons-io" />
     <depend project="antlr" />
     <depend project="jdbm" />

Re: svn commit: r111601 - /incubator/directory/kerberos/trunk/gump.xml

Posted by Niclas Hedhman <ni...@hedhman.org>.
On Sunday 12 December 2004 11:07, Brett Porter wrote:

> Can you explain what you are doing here? I've not seen "property" or
> "id" in the docs.

And I am not entirely sure it works, or Steve have make some special 
adjustments for the <ant> tag, just for Magic...

> I guess property is used to setup the override, but have no idea what id
> is used for.

Many projects produces more than one Jar, and those have a "id=" in the <jar> 
element, and you can identify those elsewhere with id= or some places ids= .

> In that case, I assume it should actually be:
>
> <depend property="maven.jar.regexp" project="jakarta-regexp" />
>
> (valid XML probably is what has been causing you issues).

Oops :o)


> I'll update the generator and put these out again. Please let me know
> what manual changes you need to make so that I can keep the automated
> goal correct.

Although others have said that the build tool and the project shouldn't adjust 
to Gump, I'm with you on this;

So, you will need 2 properties for each dependency. One for the "project" and 
one for the "id" of the project, i.e. which Jar to reference. The maven 
handler in Gump already uses the Override system in Maven, so I hoped to 
verify whether one can do the above prior to asking you for the changes in 
the Maven goal/plugin.  :o)
It may be that we need to hack the maven.py a little bit... 


Cheers
Niclas
-- 
   +------//-------------------+
  / http://www.dpml.net       /
 / http://niclas.hedhman.org / 
+------//-------------------+


Re: svn commit: r111601 - /incubator/directory/kerberos/trunk/gump.xml

Posted by Brett Porter <br...@apache.org>.
Niclas,

Can you explain what you are doing here? I've not seen "property" or 
"id" in the docs.

I guess property is used to setup the override, but have no idea what id 
is used for.

In that case, I assume it should actually be:

<depend property="maven.jar.regexp" project="jakarta-regexp" />

(valid XML probably is what has been causing you issues).

I'll update the generator and put these out again. Please let me know 
what manual changes you need to make so that I can keep the automated 
goal correct.

- Brett


niclas@apache.org wrote:

>Author: niclas
>Date: Sat Dec 11 07:59:52 2004
>New Revision: 111601
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=111601
>Log:
>More Gump stuff.
>Modified:
>   incubator/directory/kerberos/trunk/gump.xml
>
>Modified: incubator/directory/kerberos/trunk/gump.xml
>Url: http://svn.apache.org/viewcvs/incubator/directory/kerberos/trunk/gump.xml?view=diff&rev=111601&p1=incubator/directory/kerberos/trunk/gump.xml&r1=111600&p2=incubator/directory/kerberos/trunk/gump.xml&r2=111601
>==============================================================================
>--- incubator/directory/kerberos/trunk/gump.xml	(original)
>+++ incubator/directory/kerberos/trunk/gump.xml	Sat Dec 11 07:59:52 2004
>@@ -38,8 +38,8 @@
>       <property name="maven.final.name" value="eve-kerberos-@@DATE@@"/>
>     </maven>
> 
>-    <depend property="maven.regexp.jar" project="jakarta-regexp">
>-    <depend property="maven.oro.jar" project="jakarta-oro">
>+    <depend property="maven.regexp.jar" project="jakarta-regexp" id="regexp" >
>+    <depend property="maven.oro.jar" project="jakarta-oro" id="oro" >
>     <depend project="commons-io" />
>     <depend project="antlr" />
>     <depend project="jdbm" />
>
>
>
>  
>



Re: svn commit: r111601 - /incubator/directory/kerberos/trunk/gump.xml

Posted by Brett Porter <br...@apache.org>.
Niclas,

Can you explain what you are doing here? I've not seen "property" or 
"id" in the docs.

I guess property is used to setup the override, but have no idea what id 
is used for.

In that case, I assume it should actually be:

<depend property="maven.jar.regexp" project="jakarta-regexp" />

(valid XML probably is what has been causing you issues).

I'll update the generator and put these out again. Please let me know 
what manual changes you need to make so that I can keep the automated 
goal correct.

- Brett


niclas@apache.org wrote:

>Author: niclas
>Date: Sat Dec 11 07:59:52 2004
>New Revision: 111601
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=111601
>Log:
>More Gump stuff.
>Modified:
>   incubator/directory/kerberos/trunk/gump.xml
>
>Modified: incubator/directory/kerberos/trunk/gump.xml
>Url: http://svn.apache.org/viewcvs/incubator/directory/kerberos/trunk/gump.xml?view=diff&rev=111601&p1=incubator/directory/kerberos/trunk/gump.xml&r1=111600&p2=incubator/directory/kerberos/trunk/gump.xml&r2=111601
>==============================================================================
>--- incubator/directory/kerberos/trunk/gump.xml	(original)
>+++ incubator/directory/kerberos/trunk/gump.xml	Sat Dec 11 07:59:52 2004
>@@ -38,8 +38,8 @@
>       <property name="maven.final.name" value="eve-kerberos-@@DATE@@"/>
>     </maven>
> 
>-    <depend property="maven.regexp.jar" project="jakarta-regexp">
>-    <depend property="maven.oro.jar" project="jakarta-oro">
>+    <depend property="maven.regexp.jar" project="jakarta-regexp" id="regexp" >
>+    <depend property="maven.oro.jar" project="jakarta-oro" id="oro" >
>     <depend project="commons-io" />
>     <depend project="antlr" />
>     <depend project="jdbm" />
>
>
>
>  
>