You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/04 19:02:50 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #228: examples/nrf24l01_term: change macro to upper changes
xiaoxiang781216 opened a new pull request #228:
URL: https://github.com/apache/incubator-nuttx-apps/pull/228
follow up the kernel side change
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #228: examples/nrf24l01_term: change macro to upper changes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #228:
URL: https://github.com/apache/incubator-nuttx-apps/pull/228#issuecomment-623998903
need apache/incubator-nuttx#969 to fix the build break:
```
nrf24l01_term.c: In function 'wireless_cfg':
nrf24l01_term.c:125:34: error: 'RATE_1MBPS' undeclared (first use in this function); did you mean 'RATE_1Mbps'?
125 | nrf24l01_datarate_t datarate = RATE_1MBPS;
| ^~~~~~~~~~
| RATE_1Mbps
nrf24l01_term.c:125:34: note: each undeclared identifier is reported only once for each function it appears in
nrf24l01_term.c:130:14: error: 'DELAY_1000US' undeclared (first use in this function); did you mean 'DELAY_1000us'?
130 | .delay = DELAY_1000US
| ^~~~~~~~~~~~
| DELAY_1000us
make[2]: *** [/github/workspace/sources/apps/Application.mk:184: nrf24l01_term.github.workspace.sources.apps.examples.nrf24l01_term.o] Error 1
make[1]: *** [Makefile:64: /github/workspace/sources/apps/examples/nrf24l01_term_all] Error 2
make: *** [tools/LibTargets.mk:196: ../apps/libapps.a] Error 2
make: *** Waiting for unfinished jobs....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #228: examples/nrf24l01_term: change macro to upper changes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #228:
URL: https://github.com/apache/incubator-nuttx-apps/pull/228#issuecomment-623661188
It seem that nxstyle report the false alarm?
```
examples/nrf24l01_term/nrf24l01_term.c:128:2: error: Bad left brace alignment
examples/nrf24l01_term/nrf24l01_term.c:131:2: error: Bad right brace alignment
examples/nrf24l01_term/nrf24l01_term.c:138:2: error: Bad left brace alignment
examples/nrf24l01_term/nrf24l01_term.c:140:2: error: Bad right brace alignment
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org