You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/29 22:27:21 UTC

[GitHub] [airflow] jingsong commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator

jingsong commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/5915#discussion_r319296565
 
 

 ##########
 File path: airflow/contrib/kubernetes/pod_launcher.py
 ##########
 @@ -96,9 +98,14 @@ def run_pod(self, pod, startup_timeout=120, get_logs=True):
 
         return self._monitor_pod(pod, get_logs)
 
+    @tenacity.retry(
 
 Review comment:
   I'd argue that if there's underlying instability in network conditions for the operating environment of your Kubernetes pods, you'd rather have an error than trying to force the API call to go through.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services