You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/12 14:07:17 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23663: chore: Removes deprecated feature flags for 3.0
michael-s-molina opened a new pull request, #23663:
URL: https://github.com/apache/superset/pull/23663
### SUMMARY
Removes deprecated feature flags for 3.0:
- `ALLOW_DASHBOARD_DOMAIN_SHARDING`
- `DISPLAY_MARKDOWN_HTML`
- `FORCE_DATABASE_CONNECTIONS_SSL`
This is a task of the [Superset 3.0 initiative](https://github.com/orgs/apache/projects/201).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23663: chore: Removes deprecated feature flags for 3.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23663:
URL: https://github.com/apache/superset/pull/23663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23663: chore: Removes deprecated feature flags for 3.0
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23663:
URL: https://github.com/apache/superset/pull/23663#issuecomment-1505367572
## [Codecov](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23663](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (312af3a) into [master](https://codecov.io/gh/apache/superset/commit/f49702feffb3b08476c22916e185c0ce2c64e7f1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f49702f) will **decrease** coverage by `11.31%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 312af3a differs from pull request most recent head 6dc4e46. Consider uploading reports for the commit 6dc4e46 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23663 +/- ##
===========================================
- Coverage 68.00% 56.69% -11.31%
===========================================
Files 1919 1919
Lines 73977 73974 -3
Branches 8087 8086 -1
===========================================
- Hits 50305 41941 -8364
- Misses 21600 29962 +8362
+ Partials 2072 2071 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.16% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `59.49% <ø> (-23.48%)` | :arrow_down: |
| unit | `53.02% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/superset-ui-core/src/components/SafeMarkdown.tsx](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29tcG9uZW50cy9TYWZlTWFya2Rvd24udHN4) | `69.23% <ø> (+2.56%)` | :arrow_up: |
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/features/databases/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `45.36% <ø> (-0.12%)` | :arrow_down: |
| [superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==) | `73.33% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/23663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (-0.59%)` | :arrow_down: |
... and [300 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23663/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org