You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/25 15:44:07 UTC

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

dschneider-pivotal commented on a change in pull request #5289:
URL: https://github.com/apache/geode/pull/5289#discussion_r445655890



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java
##########
@@ -77,7 +78,7 @@ private void startRedisServer(InternalCache cache) {
           String.format("Starting GeodeRedisServer on bind address %s on port %s",

Review comment:
       We currently have two log messages. One says "starting" and shows the requested configuration. The other says "started" and show the actual host and port. It seems like both are worth having. Does that resolve this conversation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org