You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/04/04 00:12:04 UTC
[2/7] groovy git commit: Avoid manual array to collection copy
Avoid manual array to collection copy
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/668ec9f5
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/668ec9f5
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/668ec9f5
Branch: refs/heads/master
Commit: 668ec9f5916d67069a258a72e2b9f1c30d4cfd77
Parents: fe4224a
Author: sunlan <su...@apache.org>
Authored: Wed Apr 4 08:04:39 2018 +0800
Committer: sunlan <su...@apache.org>
Committed: Wed Apr 4 08:04:39 2018 +0800
----------------------------------------------------------------------
.../groovy-json/src/main/java/groovy/json/JsonBuilder.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/668ec9f5/subprojects/groovy-json/src/main/java/groovy/json/JsonBuilder.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-json/src/main/java/groovy/json/JsonBuilder.java b/subprojects/groovy-json/src/main/java/groovy/json/JsonBuilder.java
index 939570e..89cee15 100644
--- a/subprojects/groovy-json/src/main/java/groovy/json/JsonBuilder.java
+++ b/subprojects/groovy-json/src/main/java/groovy/json/JsonBuilder.java
@@ -27,6 +27,7 @@ import java.io.Writer;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
@@ -176,9 +177,7 @@ public class JsonBuilder extends GroovyObjectSupport implements Writable {
*/
public Object call(Object... args) {
List<Object> listContent = new ArrayList<Object>();
- for (Object it : args) {
- listContent.add(it);
- }
+ Collections.addAll(listContent, args);
content = listContent;
return content;